Chris Cormack [Thu, 22 Mar 2012 19:32:38 +0000 (08:32 +1300)]
Bug 5549 : Fixing the test to only run if the test data exists
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
test passes after the patch. Win.
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:47:49 +0000 (11:47 +0100)]
Bug 7775 - tools/upload-file.pl: scoping for plack
$uploaded_file is now scoped with our, and we set correct filename
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:05:22 +0000 (14:05 +0100)]
Bug 7799 - admin/marctagstructure.pl plack scoping
duplicate_framework needs $dbh so we get it from C4::Context
Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:28:54 +0000 (11:28 +0100)]
Bug 7773 - serials/subscription-add.pl scope for plack
This fixes scope of $query and $nextexpected
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:13:21 +0000 (14:13 +0100)]
Bug 7801 - admin/patron-attr-types.pl plack scoping
Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:08:47 +0000 (14:08 +0100)]
Bug 7800 - admin/matching-rules.pl plack scoping
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 22 Mar 2012 10:26:56 +0000 (11:26 +0100)]
Bug 7790 - tools/manage-marc-import.pl breaks with plack
transfer $template to add_matcher_list for correct scoping
and score $dbh and $runinbackground with our
Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 22 Mar 2012 12:58:29 +0000 (13:58 +0100)]
Bug 7798 - admin/item_circulation_alerts.pl plack scoping
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 22 Mar 2012 11:01:06 +0000 (12:01 +0100)]
Bug 7795 - admin/authorised_values.pl breaks with plack
scoping fixes for Variable "*" is not available errors
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Mon, 26 Mar 2012 15:53:28 +0000 (17:53 +0200)]
bug 7470 follow-up, fix POD doc
Dobrica Pavlinusic [Thu, 22 Mar 2012 11:53:13 +0000 (12:53 +0100)]
Bug 7797 - admin/currency.pl needs scoping for plack
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:23:20 +0000 (11:23 +0100)]
Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Ian Walls [Sun, 25 Mar 2012 22:20:58 +0000 (18:20 -0400)]
Bug 7743 followup: fix use of removed formattedwaitingdate param in opac-user.tt
Replaces formattedwaitingdate with just waitingdate, since no longer create and export
that template variable
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Julian Maurice [Mon, 19 Mar 2012 14:18:27 +0000 (15:18 +0100)]
Bug 7743: Update opac-readingrecord.pl to use KohaDates TT plugin
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict
Julian Maurice [Mon, 19 Mar 2012 14:05:24 +0000 (15:05 +0100)]
Bug 7743: Update opac-showreviews.pl to use KohaDates TT plugin
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Julian Maurice [Mon, 19 Mar 2012 13:57:51 +0000 (14:57 +0100)]
Bug 7743: Update opac-userupdate.pl to use KohaDates TT plugin
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Julian Maurice [Mon, 19 Mar 2012 13:49:36 +0000 (14:49 +0100)]
Bug 7743: Update sco/sco-main.pl to use KohaDates TT plugin
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Julian Maurice [Mon, 19 Mar 2012 13:43:47 +0000 (14:43 +0100)]
Bug 7743: Update opac-detail.pl to use KohaDates TT plugin
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict
Julian Maurice [Mon, 19 Mar 2012 13:28:03 +0000 (14:28 +0100)]
Bug 7743: Update opac-user.pl to use KohaDates TT plugin
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict
Julian Maurice [Mon, 19 Mar 2012 13:01:14 +0000 (14:01 +0100)]
Bug 7743: Update opac-tags.pl to use KohaDates TT plugin
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Julian Maurice [Mon, 19 Mar 2012 11:35:41 +0000 (12:35 +0100)]
Bug 7743: Update opac-account.pl to use KohaDates TT plugin
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Paul Poulain [Mon, 26 Mar 2012 14:21:31 +0000 (16:21 +0200)]
Merge remote-tracking branch 'origin/new/bug_7760'
Katrin Fischer [Fri, 23 Mar 2012 08:59:19 +0000 (09:59 +0100)]
Bug 7760: More ids and classes for the staff interface
Owen pointed out that I missed 3 files - this corrects my omission.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Gaetan Boisson [Tue, 20 Mar 2012 16:03:14 +0000 (17:03 +0100)]
Bug 7761 - cleaning up empty declarations from staff-global.css
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 22 Mar 2012 09:04:50 +0000 (10:04 +0100)]
Bug 7451 - PrepareItemrecordDisplay missing $subfield_data{id} which breaks AJAX value_builders
In current version of code, it gets initialized too late, so it produces
unitialized warnings for hidden fields (which is non-fatal) and breaks
generated JavaScript for AJAX value_builders (which is fatal)
This bug was introduced in ticket 6106 which is modification of 5955
which didn't have this particular problem.
Since then, this code moved to C4::Items because of de-nesting patches.
Test scenario:
1. define 952$i plugin: stocknumberam123.pl (this is ajax value_builder)
2. go to one of following pages and verify that plugin works:
acqui/addorderiso2709.pl
acqui/neworderempty.pl
acqui/orderreceive.pl
serials/serials-edit.pl
For stocknumberam123.pl plugin to work, you have to have at least
one item with stocknumber in format which this plugin expects:
capital letters, space, some number
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, thanks for the great test plan.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Marcel de Rooy [Wed, 21 Mar 2012 15:29:57 +0000 (16:29 +0100)]
Bug 7783: Show private shelves in opac when deleting non-empty private list from shelf view
Signed-off-by: Mathilde Formery <mathilde.formery@ville-nimes.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Sun, 11 Mar 2012 16:57:11 +0000 (12:57 -0400)]
Bug 7702: [SIGNED-OFF] MARC21 heading tests should not run under UNIMARC
Skip the MARC21-specific tests in t/Heading_MARC21.t if the marcflavour is
UNIMARC.
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I set marcflavour = UNIMARC for testing this.
Before the patch, t/Heading_MARC21.t fails. After the patch it
succeeds.
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Mon, 26 Mar 2012 13:00:47 +0000 (15:00 +0200)]
Bug 7470 follow-up
(patch from Jonathan, I don't understand why it doesn't apply cleanly, so I've rewritten it)
Paul Poulain [Mon, 26 Mar 2012 12:51:43 +0000 (14:51 +0200)]
Bug 7470 follow-up DBRev + removing `
Jonathan Druart [Fri, 2 Mar 2012 12:59:44 +0000 (13:59 +0100)]
Bug 7470: Babeltheque integration
3 features:
- adds social network information in search results
- adds babeltheque data in opac-detail
- adds social network links in opac-detail too (google+, twitter, mail
and co.)
Paul Poulain [Mon, 26 Mar 2012 12:15:14 +0000 (14:15 +0200)]
bug 7178 follow-up: typo fix
* words lower cased
* removed a space before :
Paul Poulain [Mon, 26 Mar 2012 12:14:31 +0000 (14:14 +0200)]
Bug 7178 follow-up DBRev number
Julian Maurice [Thu, 19 Jan 2012 15:59:58 +0000 (16:59 +0100)]
Bug 7178: Acquisition item creation improvement
- Display a unique item block at once
On orderreceive.pl when AcqCreateItem is 'receiving', and on
neworderempty.pl when AcqCreateItem is 'ordering' it displays an
item block with item infos to fill, and a '+' button.
When user clicks on '+', the block is hidden and a list shows up with
the items that will be received. User can then edit or delete items in
the list and click 'Save' to receive items.
- PrepareItemrecordDisplay is now used for cloning block
Previous cloning function was duplicating ids, the side effect is that
plugins didn't work when several items were displayed.
PrepareItemrecordDisplay regenerate the form with new ids
- New system preference UniqueItemFields
Contains a space-separated list of sql column names (of items table).
This syspref is used in two ways:
- Values corresponding to fields in syspref are not duplicated when
adding a new item (button 'Add')
- When saving the form, a check is made on fields in syspref for
detecting duplicate (in DB and in the form)
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests done are noted on the bug report.
2012-03-23: Fixed conflict in updatedatabase.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Wed, 21 Mar 2012 15:18:29 +0000 (16:18 +0100)]
Bug 7780: make silent/verbose flag for translation installing
This patch deal with the -v flag that you can put on translate script.
If you run without -v, the process should be silent
if you run with -v, the process should be verbose
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I've refactored your patch to handle verbosity directly via a translator
attribute, rather than with parameter which has to be send to each object call
method.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Mon, 26 Mar 2012 09:00:34 +0000 (11:00 +0200)]
big 7263 follow-up: DBRev number
Juan Romay Sieira [Tue, 20 Mar 2012 15:17:27 +0000 (16:17 +0100)]
Bug 7263 - Determine maximum length of some fields or subfields when cataloguing a biblio or an item.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Fri, 23 Mar 2012 16:16:55 +0000 (17:16 +0100)]
tiny follow-up: removing ` that are mysqlism
Chris Cormack [Thu, 22 Mar 2012 20:03:43 +0000 (09:03 +1300)]
Bug 6679 : Fixing perlcritic violation
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Fri, 23 Mar 2012 09:24:19 +0000 (10:24 +0100)]
Merge remote-tracking branch 'origin/new/bug_7548'
koha [Wed, 29 Feb 2012 22:05:21 +0000 (17:05 -0500)]
Bug 7548 Fix variable scoping in the template - Rebased
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Thu, 22 Mar 2012 17:27:02 +0000 (18:27 +0100)]
bug 6140 follow-up: DBRev number
Juan Romay Sieira [Wed, 21 Mar 2012 13:56:54 +0000 (14:56 +0100)]
Bug 6140 - Set a timeout to z3950 servers that could have network problems occasionally
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Dobrica Pavlinusic [Wed, 21 Mar 2012 13:26:02 +0000 (14:26 +0100)]
Bug 7779 - tools/letter.pl: scope vars for plack
Signed-off-by: Alex Arnaud <alex@stephane-E5420>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Thu, 22 Mar 2012 11:09:59 +0000 (12:09 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customization (reports, ...)
This is the last one - adding the classes and ids to the report module and
some template files for smaller moduls/functions.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Thu, 22 Mar 2012 10:53:48 +0000 (11:53 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customization (patroncard, labels)
After talking to Owen we decided to use 2 classes for those modules. I decided on:
patroncard: tools, pcard
labels: tools, labels
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Thu, 22 Mar 2012 10:40:09 +0000 (11:40 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customization (tools)
Prefix for ids and class is 'tools'
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Thu, 22 Mar 2012 10:19:45 +0000 (11:19 +0100)]
Add ids and classes to every staff page to help with customization (serials)
http://bugs.koha-community.org/show_bug.cgi?id=7760
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Thu, 22 Mar 2012 10:12:12 +0000 (11:12 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customization (patrons)
Class is 'pat' and ids start with 'pat_'.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Thu, 22 Mar 2012 10:00:54 +0000 (11:00 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customizaton (lists, suggestion, z39.50)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Wed, 21 Mar 2012 21:45:09 +0000 (22:45 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customizaton (circulation)
New id: circ_<filename>
New class: circ
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Wed, 21 Mar 2012 21:07:33 +0000 (22:07 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customizaton (cataloguing)
New ids: cat_<filename>
New class: cat
Exceptions:
moveitem and linkitem are accessible from the catalog pages, so have
been made 'catalog' for styling.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Wed, 21 Mar 2012 15:54:47 +0000 (16:54 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customizaton (catalog)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Wed, 21 Mar 2012 15:25:10 +0000 (16:25 +0100)]
Bug 7760: Add ids and classes to every staff page to help with customizaton (batch, error)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Wed, 21 Mar 2012 15:19:00 +0000 (16:19 +0100)]
Bug 7760: Add ids and classes to every staff page to help with customizaton (cart)
id = cart_<filename>
class = cart
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Tue, 20 Mar 2012 17:00:32 +0000 (18:00 +0100)]
Bug 7760: Add unique ids and a module class to all administration pages
This is the first patch for bug 7760 and touches all pages in administration.
This adds a unique id "admin_<filename>" and a class "admin" to the body tag of
each page in administration.
Note: aqcontract can only be accessed from the acquisition module, so I made it acq
instead of admin.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Tue, 20 Mar 2012 16:02:41 +0000 (17:02 +0100)]
Bug 7760: Add unique ids and a module class to all authorities pages
This is the first patch for bug 7760 and touches all pages in authorities.
This adds a unique id "auth_<filename>" and a class "auth" to the body tag of
each page in the authorities module.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Katrin Fischer [Tue, 20 Mar 2012 15:41:17 +0000 (16:41 +0100)]
Bug 7760: Add unique ids and a module class to all acquisitions pages
This is the first patch for bug 7760 and touches all pages in acquisitions.
This adds a unique id "acq_<filename>" and a class "acq" to the body tag of
each page in acquisitions.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Frédéric Demians [Fri, 24 Feb 2012 07:50:16 +0000 (08:50 +0100)]
SIGNED-OFF Bug 7590 Cataloging authorities search result page is broken
This bug occurs on UNIMARC DB with authorities linked together with TS/TG
relations. To reproduce it:
- Add a new biblio record
- On 610 field, click on the tag editor button to search an authority
- In the Authority search window, enter a large search
- On the result page, for authorities having relations with other terms, in the
Get it! column, you get a mess of TS/TG relations and not more Choose link.
Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Tue, 20 Mar 2012 13:24:44 +0000 (14:24 +0100)]
Bug 7765 - labels/label-edit-layout.pl: plack $layout scoping
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Tue, 20 Mar 2012 13:50:05 +0000 (14:50 +0100)]
Bug 7767 - acqui/basketgroup.pl: our $template scoping for plack
Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Thu, 22 Mar 2012 16:51:14 +0000 (17:51 +0100)]
Merge remote-tracking branch 'origin/new/bug_7768'
Dobrica Pavlinusic [Wed, 21 Mar 2012 09:43:31 +0000 (10:43 +0100)]
Bug 7768 - acqui/z3950_search.pl: remove sub displayresults to fix plack scoping
Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Thu, 22 Mar 2012 16:47:52 +0000 (17:47 +0100)]
bug 5549: follow-up DBRev number
Paul Poulain [Thu, 22 Mar 2012 16:34:26 +0000 (17:34 +0100)]
Merge remote-tracking branch 'catalyst/merged_5549' into new/bug_5549
Conflicts:
installer/data/mysql/updatedatabase.pl
members/moremember.pl
Adrien Saurat [Thu, 22 Mar 2012 09:20:14 +0000 (10:20 +0100)]
Bug 7737: applies date filters on vendor pages
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Thu, 22 Mar 2012 15:55:56 +0000 (16:55 +0100)]
Bug 7310 follow-up : typo fix lt instead of < in DB version comparison
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:01:39 +0000 (11:01 +0100)]
Bug 7769 - members/pay.pl: $template scoping for plack
Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Tue, 21 Feb 2012 06:19:54 +0000 (07:19 +0100)]
Bug 5841: Routing slip not displaying publication date
To test:
Compare output of the 2 different links for printing routing lists.
1) Links in the table of issues on the serial collection page
2) Link following the steps from editing and saving a routing list
Both previews should show the date now.
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Adrien Saurat [Tue, 20 Mar 2012 12:56:56 +0000 (13:56 +0100)]
Bug 6125: repairs dateaccessioned plugin
1/ It now works with neworderempty.pl
2/ The set_to_today function was moved from
additem.tt to dateaccessioned.pl (so it's
available to all pages using the plugin)
Signed-off-by: Julien Sicot <julien.sicot@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Thu, 22 Mar 2012 15:02:10 +0000 (16:02 +0100)]
Bug 7154 follow-up DBRev
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jonathan Druart [Fri, 10 Feb 2012 08:57:35 +0000 (09:57 +0100)]
Bug 7154: Modification in borrower attributes
* group some attributes for a more friendly display
* allow a link between a borrower category and an attribute to display
it only for the specified category
* Attr classes filled with AV 'PA_CLASS' category (you have to create AV
with a new category 'PA_CLASS' to fill class list)
this patch add 2 fields in borrower_attribute_types :
category_code
class
Signed-off-by: Julien Sicot <julien.sicot@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Thu, 22 Mar 2012 10:59:46 +0000 (11:59 +0100)]
bug 7264: follow-up DBRev number
Srdjan Jankovic [Fri, 9 Mar 2012 01:12:26 +0000 (14:12 +1300)]
bug_7264: [SIGNED-OFF] Branch popup on OPAC detail.Added opac_info field to branches table.
Signed-off-by: Delaye stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Wed, 14 Mar 2012 14:11:36 +0000 (15:11 +0100)]
Bug 7714 translating letters in fr-FR to french
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Does the job. This notifications are MySQL loadable. I've translated .txt file.
Owen Leonard [Wed, 21 Mar 2012 14:01:49 +0000 (15:01 +0100)]
Bug 5482 [Follow up] Translation problem in guided reports - Item field names
Making some additional corrections.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Tue, 20 Mar 2012 14:39:46 +0000 (15:39 +0100)]
Bug 5482: Update colums.def file
Updates the borrowers and items table descriptions using the
descriptions from the interface and the MARC21 default framework.
Biblio and biblioitems still need some work.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Owen Leonard [Tue, 20 Mar 2012 11:10:52 +0000 (12:10 +0100)]
Bug 5482 - Translation problem in guided reports - Item field names
This very minor correction adds display of the column name even
if the field description exists in the columns .def file.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changes the display to show description / table.column.
Jonathan Druart [Wed, 14 Mar 2012 13:34:27 +0000 (14:34 +0100)]
Bug 5180: FIX autocomplete on overdues report
- Switch off the CircAutocompl syspref
- Set a (one or more) patron attr type searchable
- go on the overdues page
Firebug crash and a layout problem appears on the left.
Firebug error is "YAHOO.widget.DS_XHR is not a constructor"
retry with this patch.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Marcel de Rooy [Mon, 19 Mar 2012 13:11:35 +0000 (14:11 +0100)]
Bug 7732: Restoring "More lists" in the Add-to combo of OPAC Search Results
1) More lists -> More Lists in order to be consistent with context.
2) More Lists is put just before New List at the end of the combo list. (More logical place than between your and public lists.)
3) More Lists is only shown when the number of private or public lists exceeds 9; this is a pragmatic and hard-coded approach for now. Only if there are exactly 10 lists, this does not really add a list. But who cares about that?
4) Resolves a potential bug with an [% END %] at the wrong place. Moved it after the finishing optgroup tag.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Performed a search in the OPAC without the patch and More Lists does
not appear. Applied patch and perfomred OPAC search again and the More
Lists option reappears. Signed off.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Mon, 19 Mar 2012 15:05:55 +0000 (16:05 +0100)]
Bug 7738: "Display more constraints' in subfield configuraiton is not properly translatable
The Javascript toggling the link description was checking for the english
link text. This would not work for translated templates.
Tested: Apply patch, then translate update and translate install.
Text changes as appropriate (with manually inserted translation in .po file)
Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Mon, 19 Mar 2012 16:06:23 +0000 (17:06 +0100)]
Bug 7746: "No Public Lists." not translatable.
I applied the patch and did a translate update / translate install.
No public lists is now surrounded by P-tags as expected.
Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment: fixed small typo ('pists' instead of 'lists')
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Adrien Saurat [Wed, 21 Mar 2012 14:29:50 +0000 (15:29 +0100)]
Bug 7778: fixes creation of a new server
It is now possible to add a new server
The page also now complies with the bug 2505 request
(use warnings has been added, and variables declarations
corrected to prevent warnings)
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works perfectly, tested adding, editing and deleting z39.50 servers.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Adrien Saurat [Wed, 21 Mar 2012 10:15:18 +0000 (11:15 +0100)]
Bug 7771: "Notices" changed to "Notices & Slips"
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Julian Maurice [Tue, 19 Jul 2011 10:14:00 +0000 (12:14 +0200)]
Bug 7745: Wrong service name for CAS authentification
When behind a proxy, Koha give a wrong service name to CAS server
(SCRIPT_URI environment variable). It now uses OPACBaseURL syspref.
Note: despite the OPACBaseURL description, you have to enter the
*full* URL (ie: with http:// or https://) in the syspref. (see Bug
7770)
Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Adrien Saurat [Tue, 20 Mar 2012 13:42:21 +0000 (14:42 +0100)]
Bug 7753: serials-home displays library name instead of code
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Matthias Meusburger [Fri, 2 Mar 2012 13:33:39 +0000 (14:33 +0100)]
Bug 7300 : Show working branch suggestions by default
By default, let the librarian see only suggestions made by patrons of his library.
The patron can choose to see other's as well, it's just the default.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Sun, 11 Mar 2012 17:47:18 +0000 (18:47 +0100)]
Bug 7700: Cart's more details view shows identity numbers
We already remove $9 with Koha's authority number from output
of GetMarcSubjects and GetMarcAuthors.
Patch additionally removes $0 subfields with identity numbers.
Patch also effects detail pages with normal (non-XSLT) views.
Revised to always remove $0 subfields, they are not used in UNIMARC.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Thu, 22 Mar 2012 04:05:16 +0000 (17:05 +1300)]
Merge remote-tracking branch 'kc/master' into merged_5549
Paul Poulain [Thu, 22 Mar 2012 04:00:11 +0000 (05:00 +0100)]
bug 7310 follow-up DBVersion was wrong
Thanks Ian for pointing that the DBVersion defined for 7310 was wrong : I missed it had a 99 that should have been a 00
Chris Cormack [Wed, 21 Mar 2012 20:36:55 +0000 (09:36 +1300)]
Merge remote-tracking branch 'kc/master' into merged_5549
Fixed conflicts
Conflicts:
catalogue/moredetail.pl
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
Ian Walls [Wed, 21 Mar 2012 20:03:32 +0000 (16:03 -0400)]
Bug 5549 Followup: fix suspension in days
ISO dates were being compared with DateTime objects, and DateTime::Durations
with integers. This patch reimplements the _FixFineDaysOnReturn subroutine
to use the new hourly loans functionality.
Also moves date formatting of patron debar date out of circ/returns.pl and into
KohaDates on the template
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
root [Wed, 21 Mar 2012 10:57:10 +0000 (05:57 -0500)]
Bug 5549 : fixed undefined subroutine format_date in circ/returns.pl by adding full path of C4::Dates::format_date()
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Adrien Saurat [Mon, 19 Mar 2012 16:10:16 +0000 (17:10 +0100)]
Bug 7748: use of TT date filter on addorderiso2709
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Maxime Pelletier [Wed, 22 Feb 2012 17:00:28 +0000 (12:00 -0500)]
Singlebranchmode was always 0 causing the branch to be null and the reservations in the OPAC not to work in singlebranchmode.
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>
http://bugs.koha-community.org/show_bug.cgi?id=7581
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Julian Maurice [Thu, 1 Mar 2012 08:46:49 +0000 (09:46 +0100)]
Bug 7169: Follow-up: Change booksellers search results display
- List of booksellers changed to a drop-down list
- Baskets columns renamed and reordered to make them consistent with
acqui/parcels.pl
- warning in log removed
- changed a '&' to '&' to pass W3 validator
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Julian Maurice [Fri, 13 Jan 2012 11:11:49 +0000 (12:11 +0100)]
Bug 7169: Change booksellers search results display
- Replace vendor table by a div (avoid table in a table)
- Add two columns in basket tables: biblio count and expected (not
received) items)
- Replace tablesorter by datatables
- Add a list of all returned bookseller names in top of the page (easier
to find a bookseller in a large list of results)
Kyle M Hall [Thu, 8 Mar 2012 19:35:08 +0000 (14:35 -0500)]
Bug 7597 - Part 5 - Remove my from $branch, which was masking previous declaration
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Mon, 5 Mar 2012 20:29:44 +0000 (15:29 -0500)]
Bug 7597 - Part 4 - Change C4::Acounts::WriteOff to WriteOffFee
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Kyle M Hall [Tue, 28 Feb 2012 14:34:59 +0000 (09:34 -0500)]
Bug 7597 - Part 3 - fines not recording the right info in the stats table
This commit fixes writeoff_all to write off only the amount outstanding
for each fine being written off, rather than the original amount owed.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested all three patches together and was able to write off single
and multiple fines and the data was correct in the stats table.
Kyle M Hall [Tue, 28 Feb 2012 14:17:04 +0000 (09:17 -0500)]
Bug 7597 - Part 2 - move sub writeoff to C4::Accounts
Currently, the subroutine writeoff lives in pay.pl, which
is a violation of the Koha coding guidelines, as it writes
to the database. This commit restructures and moves writeoff
to C4::Accounts::WriteOff(), and modifies pay.pl to use it.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested all three patches together and was able to write off single
and multiple fines and the data was correct in the stats table.