]> git.koha-community.org Git - koha.git/commit
Bug 11281: Printing holds awaiting pickup prints both tabs
authorOwen Leonard <oleonard@myacpl.org>
Fri, 22 Nov 2019 19:29:53 +0000 (19:29 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Thu, 5 Mar 2020 00:35:38 +0000 (00:35 +0000)
commit30145385916935464ccbc52a1a13755464863ef9
tree934aa59112f81c63f62ba0b4da9b67fa92365eba
parent905c0bc5e0831148c8334a92863ec9289e2c67b5
Bug 11281: Printing holds awaiting pickup prints both tabs

This patch adds columns configuration to the holds awaiting pickup
tables. Doing so helps solve the printing issue by adding a "Print"
option to both tables. Using this print function will provide a
printable version of only that table.

To test you should have multiple holds in your system which are marked
"waiting" and some which have been waiting longer than the value
specified in the ReservesMaxPickUpDelay system preference.

Apply the patch and go to Circulation -> Holds awaiting pickup.

 - On both the "Holds waiting" and "Holds waiting over..." tabs the
   DataTable should display correctly and all the controls should work,
   including the columns settings and the choices in the export menu.
 - Confirm that the "Print" action creates a printable version of only
   the table you are viewing.

 - Go to Administration -> Columns settings -> Circulation.
 - Change some visibility controls for the tables under the
   "holds_awaiting_pickup" heading (id=holdso and id=holdst). Confirm
   that these changes are reflected in the "Holds waiting" interface.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
admin/columns_settings.yml
koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc
koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt