]> git.koha-community.org Git - koha.git/commit
Bug 24878: Add authentication checks to the calendar tool
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 16 Mar 2020 15:26:48 +0000 (16:26 +0100)
committerJoy Nelson <joy@bywatersolutions.com>
Mon, 23 Mar 2020 23:52:10 +0000 (23:52 +0000)
commit656e7814b34d07534fa3a044f9cc7a8f4f4feea6
tree5a33ba240529d38df91050c217ddd5ec1ae3f81b
parent95e24ed2dcda660079111fd45a2cd31e3e481b86
Bug 24878: Add authentication checks to the calendar tool

There is a security hole in 2 scripts that are used by the UI to edit
holidays.

To test:
1) Go to Tools -> Calendar, for Centerville
   Check no holiday for 30/4/2020
2) To add a new holiday without login execute
   a curl command with necessary parameters
3) Reload page from 1), verify the new holiday
   edit and delete the holiday
4) Apply the patch
5) Do 2) again, this time you get a lengthy output,
   with the magic words:

   <title>Koha &rsaquo;
       Log in to Koha
   </title>

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Only tested newHoliday but the fix is the same.
No errors

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
tools/exceptionHolidays.pl
tools/newHolidays.pl