]> git.koha-community.org Git - koha.git/commit
Bug 20754: DB revision to remove double accepted shares
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 4 May 2018 08:42:38 +0000 (10:42 +0200)
committerJoy Nelson <joy@bywatersolutions.com>
Wed, 29 Apr 2020 20:39:22 +0000 (20:39 +0000)
commitba3bed7afe84b9e5278bed0aa12d71bfc82b4c9d
tree318bc80966bd5475c265a8aff111b333f152e3ae
parent4ed413a76a32c52db71aae5efc2d3edf1949cc2c
Bug 20754: DB revision to remove double accepted shares

[Originally submitted for bug 11943, parked at 20754.]
[Attempt to revive it now.]

Although it is no problem to have them, we could do a cleanup.
This patch just removes duplicate rows from the table.

Note: I considered adding a unique index like:
    ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber, borrowernumber, invitekey);
But the possible NULL values in borrowernumber and/or invitekey require
additional code changes. So I left it alone.

Test plan:
[1] Create two records with same borrowernumber and shelfnumber in the shares
    table, if not present already.
[2] Run updatedatabase.pl

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
installer/data/mysql/atomicupdate/bug20754.perl [new file with mode: 0644]