]> git.koha-community.org Git - koha.git/commit
Bug 26043: Fix random failure from Holds.t
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 22 Jul 2020 12:11:03 +0000 (14:11 +0200)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Sun, 16 Aug 2020 21:34:04 +0000 (09:34 +1200)
commitc106d5a29d32572276489b5b1f3b8941ab17c778
tree25eacbdf3c8fcfc750592d0e1cfc0d05e91ea4e8
parent22809514f581dde652f2ab96dad1dc7cdfb5d1ac
Bug 26043: Fix random failure from Holds.t

 #   Failed test 'Test ModReserveMinusPriority()'
 #   at t/db_dependent/Holds.t line 202.
 #          got: undef
 #     expected: '1605'
 # Looks like you failed 1 test of 66.

It is coming from Koha::Patron->holds that is ordering by reservedate,
so "sometimes" they are ordered in reverse (at least it's my
understanding of the problem).

Test plan:
Run the test file several times (from 20 to 60x), it must never fail
with this patch

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 80a611797bf67b263b6b84a6e931833ea336b6a5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit c98a283d118bb936dc44db1b73cfeb8e45f89a22)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
t/db_dependent/Holds.t