]> git.koha-community.org Git - koha.git/commit
Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull"
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 28 May 2020 10:11:37 +0000 (12:11 +0200)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Mon, 22 Jun 2020 03:54:59 +0000 (15:54 +1200)
commitd680ae35f39c0eb413b45339aadfa9148a58ed55
tree42504ff0c66850f76909cb7a1ca093c334ac6d9d
parent4c536ffbcecfeeb9e6d6473e7c7c4cddfe4c5006
Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull"

On the "Holds to pull" view there are filters that are built on the
value of the cells.
Bug 22536 improved the ergonomic by adding a ul list, but the filters
are now broken, the ul and li tags are retrieved and put in the filter
list.

The idea of this patch is to remove the HTML tags and skip if the value
is then empty.

Test plan:
Place a hold on an item
Go to Home › Circulation › Holds to pull
Open the "libraries" filter
=> Without this patch you see empty entries
=> With this patch the filter contain only the libraries

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 4f70682c56dddd42f24c62d7634f5cd3b7119702)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 58c071fad3f63de8e069baa84ddea9656e689913)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt