From 037e6c7e48f5f499ef89ce181f2e8aca9dff6893 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 15 Nov 2022 14:13:53 +0000 Subject: [PATCH] Bug 32045: Use bootstrap tabs to select item tab When the form to add orders from a staged file is validated, we use toptabs functionality to switch to the item tab if there are missing fields. The display now uses bootstrap tabs, so the JS is throwing an error: Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option' This patch simply switches the call to switch tabs To test: 1 - Stage a file for import 2 - Either use Marc(Item)FieldsToOrder to populate the orders or select a budget on the third tab 3 - View the second tab, items info, confirm itemtype is required, but don't populate it 4 - Attempt to save order, nothing happens 5 - Check the JS console (F12) 6 - Note the error: Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option' 7 - Apply patch 8 - Cancel and add from staged file again 9 - Select a budget and save 10 - You now get an error popup: Some required item subfields are not set 11 - Confirm after the error you are shown the items tab 12 - Select itemtype 13 - Save 14 - Confirm orders added successfully Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js index 34785cda2c..8b960108a1 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js +++ b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js @@ -73,7 +73,7 @@ $(document).ready(function() { if (0 < CheckMandatorySubfields(this.form)) { // Open the item tab - $('#tabs').tabs('option', 'active', 1); + $('.nav-tabs .items_info').tab('show'); alert(__('Some required item subfields are not set')); return false; -- 2.20.1