From 065c955cc67b6f113c9fb5d5ed918ba1400b5af9 Mon Sep 17 00:00:00 2001 From: Eden Bacani Date: Tue, 19 Jan 2021 21:21:51 +0000 Subject: [PATCH] Bug 27395: Add a warning to PatronSelfRegistrationDefaultCategory This patch adds a warning to the PatronSelfRegistrationDefaultCategory system preference to not use a regular patron category for self registration. If a regular patron category code is used and the cleanup_database cronjob is setup to delete unverified and unfinished OPAC self registrations, it permanently and and unrecoverably deletes all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago. It also removes unnecessary apostrophes at the end of two self registration and modification system preference descriptions. Test plan: 1. Apply the patch. 2. Check that the warning message for the PatronSelfRegistrationDefaultCategory system preference is clear and makes sense. 3. Sign off! Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../prog/en/modules/admin/preferences/opac.pref | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index d1973f272c..145fb0e06b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -796,7 +796,7 @@ OPAC: yes: Allow no: "Don't allow" - "library patrons to register for an account via the OPAC." - -
NOTE: This needs PatronSelfRegistrationDefaultCategory to be set to a valid patron category code.' + - "
NOTE: This needs PatronSelfRegistrationDefaultCategory to be set to a valid patron category code." - - pref: PatronSelfRegistrationVerifyByEmail choices: @@ -809,8 +809,9 @@ OPAC: - pref: PatronSelfRegistrationDefaultCategory class: short - "as the default patron category for patrons registered via the OPAC." + - "
WARNING: Do not use a regular patron category for self registration. If the misc/cronjobs/cleanup_database.pl cronjob is setup to delete unverified and unfinished OPAC self registrations, it will permanently and unrecoverably delete all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago." - - - Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory' + - Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory - pref: PatronSelfRegistrationExpireTemporaryAccountsDelay class: integer - "days after account creation." -- 2.39.5