From 118907bcdd445e797f4da974742c35325d492a48 Mon Sep 17 00:00:00 2001
From: arensb <arensb>
Date: Sun, 13 Oct 2002 06:03:03 +0000
Subject: [PATCH] Added some FIXME comments. Added RCS magic comment. Removed
 unused finalizer.

---
 C4/Circulation.pm | 10 +++++-----
 C4/Format.pm      | 11 ++++++-----
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index 07dcf98e2f..b7ea8f1c82 100755
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -1,4 +1,6 @@
-package C4::Circulation; #assumes C4/Circulation
+package C4::Circulation;
+
+# $Id$
 
 #package to deal with circulation 
 
@@ -125,6 +127,7 @@ sub checkoverdues{
 }
 
 # FIXME - This is quite similar to &C4::Circulation::Main::previousissue
+# FIXME - Never used. Obsolete, presumably.
 sub previousissue {
   my ($env,$itemnum,$dbh,$bornum)=@_;
   my $sth=$dbh->prepare("Select firstname,surname,issues.borrowernumber,cardnumber,returndate
@@ -208,10 +211,7 @@ sub scanborrower {
   my ($env,$interface)=@_;
   #scan barcode
   my ($number,$reason,$book)=&borrower_dialog($env); #C4::Interface
-  $number= $number;
+  $number= $number;		# FIXME - WTF?
   $book=uc $book;
   return ($number,$reason,$book);
 }
-
-
-END { }       # module clean-up code here (global destructor)
diff --git a/C4/Format.pm b/C4/Format.pm
index 306b181cc9..f7d6ed90a9 100755
--- a/C4/Format.pm
+++ b/C4/Format.pm
@@ -1,5 +1,6 @@
-package C4::Format; #assumes C4/Format
+package C4::Format;
 
+# $Id$
 
 # Copyright 2000-2002 Katipo Communications
 #
@@ -121,6 +122,8 @@ value.
 If C<$format> has a comma after the optional dollar sign, the integer
 part will be split into three-digit groups separated by commas.
 
+C<$env> is effectively ignored.
+
 =cut
 #'
 # FIXME - This is all terribly provincial, not at all
@@ -210,15 +213,13 @@ sub fmtdec {
   }
   # Right-pad the decimal part to the given number of digits.
   if ($right > 0) {
-     $tempdec = $tempdec.("0"x$right);
+     $tempdec = $tempdec.("0"x$right);	# FIXME - .=
      $tempdec = substr($tempdec,0,$right);
-     $fnumb = $fnumb.".".$tempdec;
+     $fnumb = $fnumb.".".$tempdec;	# FIXME - .=
   }
   return ($fnumb);	# FIXME - Shouldn't return a list.
 }
 
-END { }       # module clean-up code here (global destructor)
-
 1;
 __END__
 
-- 
2.39.5