From 14205d3b455cf087483e515d5fcba32affbee636 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 25 Oct 2022 11:46:12 +0000 Subject: [PATCH] Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- .../prog/en/modules/admin/background_jobs.tt | 100 ++++++++++-------- 1 file changed, 53 insertions(+), 47 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt index 74386ddec9..0554cd3ae4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt @@ -73,38 +73,42 @@ [% PROCESS "background_jobs/${job.type}.inc" %] - + [% IF CAN_user_parameters_manage_background_jobs %]
@@ -127,20 +131,22 @@ - - - - - - - - - - - - - -
Job IDStatusProgressTypeQueuedStartedEndedActions
+
+ + + + + + + + + + + + + +
Job IDStatusProgressTypeQueuedStartedEndedActions
+
[% END %] @@ -237,7 +243,7 @@ [% IF op == 'view' %] $("#job_status_description").html( get_job_status("[% job.status | html %]") ); $("#job_type_description").html( get_job_type("[% job.type | html %]") ); - $("fieldset.rows").show(); + $("#job_details").show(); [% END %] let additional_filters = { -- 2.39.5