From 14986fce53b8bfa6fe3d597f6c255ca742ef17c5 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 9 Jul 2020 10:25:26 +0100 Subject: [PATCH] Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- Koha/Illrequest.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm index 4a3eb566cd..6e4f64761c 100644 --- a/Koha/Illrequest.pm +++ b/Koha/Illrequest.pm @@ -1556,6 +1556,7 @@ sub get_notice { my $letter = C4::Letters::GetPreparedLetter( module => 'ill', letter_code => $params->{notice_code}, + branchcode => $self->branchcode, message_transport_type => $params->{transport}, lang => $self->patron->lang, tables => { @@ -1565,8 +1566,8 @@ sub get_notice { branches => $self->branchcode, }, substitute => { - ill_bib_title => $title ? $title->value : 'N/A', - ill_bib_author => $author ? $author->value : 'N/A', + ill_bib_title => $title ? $title->value : qw{}, + ill_bib_author => $author ? $author->value : qw{}, ill_full_metadata => $metastring } ); -- 2.39.5