From 1bc7b45698559d81331ca149d2db3d26e85a78b2 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Sat, 20 Feb 2021 09:57:20 +0000 Subject: [PATCH] Bug 27715: (QA follow-up) Remove conditional declaration Resolves: FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers (cherry picked from commit c8d14a8087a57d6859b283188e8e1b1a0343dfda) Signed-off-by: Andrew Fuerste-Henry --- C4/Utils/DataTables.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/C4/Utils/DataTables.pm b/C4/Utils/DataTables.pm index 23c7ebd405..6e1af15611 100644 --- a/C4/Utils/DataTables.pm +++ b/C4/Utils/DataTables.pm @@ -116,8 +116,7 @@ sub dt_build_orderby { push @sanitized_orderbys, "$sanitized_identifier $sanitized_direction"; } - my $orderby = " ORDER BY " . join(',', @sanitized_orderbys) . " " if @sanitized_orderbys; - return $orderby; + return " ORDER BY " . join(',', @sanitized_orderbys) . " " if @sanitized_orderbys; } =head2 dt_get_params -- 2.39.5