From 292c0ea24d73f9d5ad992b1c97ef872e3b962888 Mon Sep 17 00:00:00 2001 From: Hammat Wele Date: Mon, 3 Apr 2023 21:04:28 +0000 Subject: [PATCH] Bug 33343: Make use of the 'autocomplete=off' attribute on password fields This patch adds 'autocomplete=off' to all password type fields in the OPAC To test: 1. Apply the patch 2. Visit http://master/cgi-bin/koha/opac-main.pl 3. Inspect the page --> Confirm html shows autocomplete off on the password field 4. Click on Log in (without filling any field) 5. Repeat step 3 --> Confirm html shows autocomplete off on the password field 6. Set 'PatronSelfRegistration' system preference to 'Allow' and PatronSelfRegistrationDefaultCategory to 'Board' 7. Visit http://master/cgi-bin/koha/opac-memberentry.pl 9. Repeat step 3 --> Confirm html shows autocomplete off on the password field 10. Connect to the OPAC 11. Click on Change password 11. Repeat step 3 --> Confirm html shows autocomplete off on the password field 12. Set 'EnableExpiredPasswordReset' system preference to 'Enable' 13. Visit http://master/cgi-bin/koha/opac-reset-password.pl 14. Repeat step 3 --> Confirm html shows autocomplete off on the password field Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi --- .../opac-tmpl/bootstrap/en/includes/overdrive-login.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 6 +++--- .../bootstrap/en/modules/opac-password-recovery.tt | 4 ++-- .../en/modules/opac-registration-confirmation.tt | 8 ++++---- .../opac-tmpl/bootstrap/en/modules/opac-reset-password.tt | 2 +- 7 files changed, 15 insertions(+), 15 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc index cf3ea1912d..10e862d41f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc @@ -11,7 +11,7 @@