From 2fa6105779d02e9b7fa81bc0ea47bff51e9f3170 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Tue, 16 May 2023 11:14:01 +0000 Subject: [PATCH] Bug 33744: Fix cloning (sub)fields with framework plugins This patch is meant as a temporary measure for fixing the problem. Bug 30975 may resolve it further, but this is good for now. Note: The original commit message referred to removing a deprecated internal structure. But this patch actually still uses the structure which has been moved to _data in jQuery now. Test plan: 1) Apply patch 2) Repeat steps in the original bug description 3) This time clicking on the Upload button for a cloned field should launch the uploads pop up. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js index 602ae9ceaf..8808df2c71 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js @@ -436,7 +436,7 @@ function AddEventHandlers (oldcontrol, newcontrol, newinputid ) { // newinputid is the id attribute of the cloned controlling input field // Note: This code depends on the jQuery data for events; this structure // is moved to _data as of jQuery 1.8. - var ev= $(oldcontrol).data('events'); + var ev = $._data(oldcontrol, "events"); if(typeof ev != 'undefined') { $.each(ev, function(prop,val) { $.each(val, function(prop2,val2) { -- 2.20.1