From 30c7dd1866138c226284949b1f6bc75ff019c466 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 28 Jan 2022 09:49:44 +0100 Subject: [PATCH] Bug 29962: (bug 27526 follow-up): Fix columns button on item list The "Columns" button on the item list view has been broken (hidden) by bug 27526. "column_name" was removed from the item_header_loop: - if ( $kohafield && $kohafield =~ /items.(.+)/ ) { - $header_value{column_name} = $1; - } We can still access the attribute name using 'attribute' however. The difference is that non-mapped subfield will have an "attribute", but there is a net to prevent a crash in columns_settings.inc: 12 var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); 13 var used_id = dt_parameters.bKohaColumnsUseNames ? named_id : counter; 14 if ( used_id == -1 ) return; We should simply pass attribute. Test plan: Create a non-mapped subfield (952$k) Edit an item, add a value for k On the item table at the top of the edit form notice that the "Columns" button is back and that it's working correctly. Note that 'k' cannot be hidden (may be considered as a bug, but it's not a regression). Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens Signed-off-by: Fridolin Somers --- .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt index b6fb2317bb..825e4c1c3a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ -72,11 +72,7 @@   [% FOREACH item_header IN item_header_loop %] - [% IF item_header.column_name %] - - [% ELSE %] - - [% END %] + [% item_header.header_value | html %] [% END %] -- 2.39.5