From 3afd4a7e1aff525d870aef5d4693016885a6dbcf Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 22 Dec 2017 15:21:51 -0300 Subject: [PATCH] Bug 19564: Add tests for _convert_sort_fields Signed-off-by: Nicolas Legrand Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart --- .../Koha_SearchEngine_Elasticsearch_Search.t | 25 ++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t b/t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t index 865a6ce1f4..de7ef95a47 100644 --- a/t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t +++ b/t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t @@ -17,7 +17,7 @@ use Modern::Perl; -use Test::More tests => 12; +use Test::More tests => 13; use t::lib::Mocks; use Koha::SearchEngine::Elasticsearch::QueryBuilder; @@ -229,3 +229,26 @@ subtest 'build_query tests' => sub { ); }; +subtest "_convert_sort_fields" => sub { + plan tests => 1; + my @sort_by = $builder->_convert_sort_fields(qw( call_number_asc author_dsc )); + is_deeply( + \@sort_by, + [ + { field => 'callnum', direction => 'asc' }, + { field => 'author', direction => 'desc' } + ], + 'sort fields should have been split correctly' + ); + + # We could expect this to pass, but direction is undef instead of 'desc' + #@sort_by = $builder->_convert_sort_fields(qw( call_number_asc author_desc )); + #is_deeply( + # \@sort_by, + # [ + # { field => 'callnum', direction => 'asc' }, + # { field => 'author', direction => 'desc' } + # ], + # 'sort fields should have been split correctly' + #); +}; -- 2.20.1