From 41fbb64fab3e2dbb259f57ac1b0ea0a81bc41447 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 3 Oct 2014 12:24:36 -0400 Subject: [PATCH] Bug 11271 - Serials table off the screen in smaller viewports When you search for serials in the Serials module the results table is often too wide for the screen (depending on your browser window size). This is partly due to the fixed width of the search fields in the table footer. This patch applies a flexible width to those s and reduces the font size of their text. This patch also moves the "action" links for each table row into an "action" menu (similar to the change made by Bug 10615 in Reports) to further conserve screen space. This patch also revises the page's DataTables configuration to use table header classes for sorting configuration. To test you should be able to perform a search which returns multiple open and closed subscriptions. - Test that table sorting works correctly, including for titles with articles and for dates. - Test that the Action menu items work correctly and that they correctly reflect the permissions of the logged-in user with regard to receive_serials and routing. - Perform these tests on both the "Open" and "Closed" tabs. Signed-off-by: Chris Signed-off-by: Katrin Fischer Works nicely and improves the display significantly. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi --- .../prog/en/includes/serials-toolbar.inc | 2 +- .../prog/en/modules/serials/serials-search.tt | 163 +++++++++--------- 2 files changed, 87 insertions(+), 78 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc index efc32dd9f0..d02781a97f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc @@ -80,7 +80,7 @@ [% END %] [% IF CAN_user_serials_edit_subscription %] [% IF closed %] - + [% ELSE %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt index 561e0329d6..ae1484d0d1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt @@ -11,34 +11,24 @@ // + [% INCLUDE 'header.inc' %] @@ -147,30 +138,24 @@ ISSN - Title - Notes + Title + Notes Library Location Call number - Expiration date - [% IF ( routing && CAN_user_serials_routing ) %] - Routing list - [% END %] -   -   + Expiration date + Actions - - - - - - - - [% IF ( routing && CAN_user_serials_routing ) %][% END %] - + + + + + + + @@ -203,27 +188,41 @@ [% END %] - [% IF ( routing && CAN_user_serials_routing ) %] - - [% IF ( subscription.cannotedit ) %] -   - [% ELSE %] - [% IF ( subscription.routingedit ) %] - Edit - ([% subscription.routingedit %]) - [% ELSE %] - New - [% END %] - [% END %] - - [% END %] - Issue history - + - [% IF ( CAN_user_serials_receive_serials ) %] - Serial receive - [% END %] + + [% END %] [% END %] @@ -241,24 +240,22 @@ ISSN - Title - Notes + Title + Notes Library Location Call number -   -   + Actions - - - - - - - + + + + + + @@ -288,14 +285,26 @@ [% IF ( subscription.callnumber ) %][% subscription.callnumber %][% END %] - [% UNLESS subscription.cannotedit %] - Reopen - [% ELSE %] - Cannot edit - [% END %] - - - Issue history + [% END %] -- 2.39.5