From 43519c0525a07b8f784fd9166eb0db3430e29042 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Fri, 4 Oct 2019 13:19:18 +0100 Subject: [PATCH] Bug 23612: (RM follow-up) Fix failing tests Trailing comma's were causing hidden javascript errors during selenium tests. Error was identified by adding a $s->capture($driver) line to the relevant selenium test and using the following JS snippet to dump errors to the screen. (function () { var ul = null; function createErrorList() { ul = document.createElement('ul'); ul.setAttribute('id', 'js_error_list'); //ul.style.display = 'none'; document.body.appendChild(ul); } window.onerror = function(msg){ if (ul === null) createErrorList(); var li = document.createElement("li"); li.appendChild(document.createTextNode(msg)); ul.appendChild(li); }; })(); Which clearly showed the following error. ReferenceError: KohaTable is not defined Removing the trailing comma's introduced in this bug resolved the issue. Signed-off-by: Martin Renvoize --- .../intranet-tmpl/prog/en/includes/columns_settings.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc index a5c5e0c8c6..f02ad89151 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc @@ -69,7 +69,7 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) { dt.search( "" ).draw("page"); node.addClass("disabled"); } - }, + } ]; if( included_ids.length > 0 ){ @@ -83,8 +83,8 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) { text: ' ' + _("Columns") + '', exportOptions: { columns: exportColumns - }, - }, + } + } ); } -- 2.39.5