From 457ae7e20567e9a46ee5ceae9e8cb130064b84ba Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 14 Jan 2014 15:04:27 -0500 Subject: [PATCH] Bug 11541: (follow-up) repair some warnings Tests succeed, but cause many warnings: prove t/Installer.t t/Installer.t .. 1/9 "my" variable $self masks earlier declaration in same scope at t/Installer.t line 19. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 20. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 21. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 22. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 23. Odd number of elements in anonymous hash at t/Installer.t line 17. Use of uninitialized value within @ARGV in anonymous hash ({}) at t/Installer.t line 17. The patch remedies that. Test Plan: 1) Apply first patch on this bug 2) Run "prove t/Installer.t" 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) Note the warnings are gone Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton --- t/Installer.t | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/t/Installer.t b/t/Installer.t index a94bdd585b..cc786d879d 100644 --- a/t/Installer.t +++ b/t/Installer.t @@ -13,11 +13,12 @@ BEGIN { use_ok('C4::Installer'); } +my $self; ok ( my $installer = C4::Installer->new(), 'Testing NewInstaller' ); ok ( my $class = {shift}, 'Testing Shift' ); -ok ( my $self->{'dbname'} = C4::Context->config("database"), 'Testing DbName' ); -ok ( my $self->{'dbms'} = C4::Context->config("db_scheme") ? C4::Context->config("db_scheme") : "mysql", 'Testing DbScheme' ); -ok ( my $self->{'hostname'} = C4::Context->config("hostname"), 'Testing Hostname' ); -ok ( my $self->{'port'} = C4::Context->config("port"), 'Testing Port' ); -ok ( my $self->{'user'} = C4::Context->config("user"), 'Testing User' ); -ok ( my $self->{'password'} = C4::Context->config("pass"), 'Testing Password' ); +ok ( $self->{'dbname'} = C4::Context->config("database"), 'Testing DbName' ); +ok ( $self->{'dbms'} = C4::Context->config("db_scheme") ? C4::Context->config("db_scheme") : "mysql", 'Testing DbScheme' ); +ok ( $self->{'hostname'} = C4::Context->config("hostname"), 'Testing Hostname' ); +ok ( $self->{'port'} = C4::Context->config("port"), 'Testing Port' ); +ok ( $self->{'user'} = C4::Context->config("user"), 'Testing User' ); +ok ( $self->{'password'} = C4::Context->config("pass"), 'Testing Password' ); -- 2.20.1