From 45e8f2f5c600094f90f938b1b30d81c236d10020 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 6 Aug 2020 12:50:36 +0200 Subject: [PATCH] Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file There is a ->store call missing when we attempt to create a new item. Test plan: - set at least one value in MARCItemFieldsToOrder - add to a basket via staged file with at least one value matching your MARCItemFields mappings - set required fields for your order and click Save => Without this patch you got: receive error: "DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /kohadevbox/koha/Koha/Acquisition/Order.pm line 113 at /usr/share/perl5/DBIx/Class/Exception.pm line 77" => With this patch applied the order has been created successfully Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 12e1b2faccf6396d3c4b5327c881e78f177f135b) Signed-off-by: Lucas Gass (cherry picked from commit 5e972d95ac834859ec5f9eabae0b2c20f7754818) --- acqui/addorderiso2709.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl index b9fa2395c9..acc386192c 100755 --- a/acqui/addorderiso2709.pl +++ b/acqui/addorderiso2709.pl @@ -236,7 +236,7 @@ if ($op eq ""){ replacementprice => $replacementprices[$i], itemcallnumber => $itemcallnumbers[$i], } - ); + )->store; push( @itemnumbers, $item->itemnumber ); } if ($itemcreation == 1) { -- 2.39.5