From 4881ecece5d8fcdac867d7b6936923d451a3d48a Mon Sep 17 00:00:00 2001
From: Jane Sandberg <sandbej@linnbenton.edu>
Date: Sun, 16 Sep 2018 11:59:40 -0700
Subject: [PATCH] Bug 13406: Add styling classes to authority MARC detail
 display

When viewing authority MARC records in the staff client (detail view), the
MARC tags were not displaying with the tag_num, tag_desc, tag_ind1,
tag_ind2, and desc classes, which made it impossible to add styles
to these specific parts of a MARC tag.  This commit adds these
styles (which are the same as the classes in the bibliographic
MARC detail display).

To test:
1) Open the staff client, then click Authorities.
2) Search for an authority record.
3) Click on Details.
4) Examine some MARC fields.  Note that the entire tag title line
is in a single <div>.
5) Apply this commit.
6) Repeat steps 1-3.
7) Notice that the tag title line is now separated into several
spans, each with their own classes.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 05e51e9574884f03034633dfef95e7e95ac0224e)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 authorities/detail.pl                                |  7 +++++++
 .../prog/en/modules/authorities/detail.tt            | 12 ++++++++----
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/authorities/detail.pl b/authorities/detail.pl
index 4589c62f83..b2532385d9 100755
--- a/authorities/detail.pl
+++ b/authorities/detail.pl
@@ -143,7 +143,14 @@ sub build_tabs {
                                      . C4::Koha::display_marc_indicators($field) 
                                      . ' - '
                                      . $tagslib->{$field->tag()}->{lib};
+                      $tag_data{tag_number} = $tag;
+                      $tag_data{tag_desc} = $tagslib->{$field->tag()}->{lib};
                       $tag_data{subfield} = \@subfields_data;
+                      if ($tag >= 10){ # no indicator for theses tag
+                            $tag_data{ind1} = $field->indicator(1);
+                            $tag_data{ind2} = $field->indicator(2);
+                      }
+
                       push (@loop_data, \%tag_data);
                     }
                   }
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
index 2dc44b4eda..27aecc9d43 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
@@ -64,7 +64,11 @@
         [% IF ( innerloo.tag ) %]
             <div class="tag">
             <div class="tag_title">
-                [% innerloo.tag %]
+                <span class="tag_num">[% innerloo.tag_number | html %]</span>
+                [% IF (innerloo.defined("ind1") ) %]
+                    <span class="tag_ind1">[% innerloo.ind1 %]</span><span class="tag_ind2">[% innerloo.ind2 | html %]</span>
+                [% END %]
+                [% IF (innerloo.tag_desc) %]<span class="dashwrapper"> -</span> <span class="tag_desc">[% innerloo.tag_desc | html %]</span>[% END %]
             </div>
         [% ELSE %]
             <div class="tag">
@@ -72,9 +76,9 @@
         [% FOREACH subfiel IN innerloo.subfield %]
             <p>
                 <label class="labelsubfield">&nbsp;
-                [% UNLESS ( subfiel.hide_marc ) %]<b>[% subfiel.marc_subfield %]</b>[% END %]
-                <span title="[% subfiel.long_desc %]">[% subfiel.short_desc %]</span></label>
-                [% subfiel.marc_value %]
+                [% UNLESS ( subfiel.hide_marc ) %]<b>[% subfiel.marc_subfield | html %]</b>[% END %]
+                <span title="[% subfiel.long_desc | html %]" class="desc">[% subfiel.short_desc | html %]</span></label>
+                [% subfiel.marc_value | html %]
                 [% IF ( subfiel.link ) %]
                     <a href="/cgi-bin/koha/catalogue/search.pl?op=do_search&amp;marclist=[% subfiel.link %]&amp;operator==&amp;type=intranet&amp;value=[% subfiel.marc_value |url %]">
                         <img src="[% interface %]/[% theme %]/images/filefind.png" height="15" title="Search on [% subfiel.marc_value %]">
-- 
2.39.5