From 4a3ae69173950456908cd22c6bac273fffae3f1a Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 22 May 2023 15:54:14 +0100 Subject: [PATCH] Bug 33343: Catch more cases and correctly use new-password hint I believe where we're allowing a user to set a new password instead of using autocomplete="off" we should be hinting to the brownser that it's a new password box with autocompelte="new-password". I also correct a couple of missing instances.. Honestly, I'm not sure how much this helps these days as most browsers offer to save passwords regardless. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi --- .../prog/en/modules/admin/smtp_servers.tt | 10 +++++----- .../prog/en/modules/members/member-password.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 8 ++++---- .../bootstrap/en/modules/opac-reset-password.tt | 6 +++--- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt index 7fdb5624a7..206f53950a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt @@ -112,11 +112,11 @@
  • - +
  • - +
  • @@ -191,14 +191,14 @@
  • - +
  • [% IF smtp_server.password %] - + [% ELSE %] - + [% END %]
  • diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt index 8680830857..261611a1d8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt @@ -88,11 +88,11 @@ [% END %]
  • - +
  • - +
  • Koha cannot display existing passwords. Leave the field blank to leave password unchanged.
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index e30eadcb09..89a9e841e0 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -925,11 +925,11 @@
    1. - +
      Required
    2. - +
      Required
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt index 5b0ab95dd5..8f08befe98 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt @@ -64,7 +64,7 @@ [% IF logged_in_user.category.effective_change_password %] [% IF ( Ask_data ) %] -
    + Change your password
    [% IF ( logged_in_user.category.effective_require_strong_password ) %] @@ -74,15 +74,15 @@ [% END %]
    - +
    - +
    - +
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt index 4aa2070b46..440fdac457 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt @@ -84,15 +84,15 @@
    - +
    - +
    - +
    -- 2.39.5