From 4bddc658c27b627231fc44e4d13c7c54c39c3e60 Mon Sep 17 00:00:00 2001 From: arensb Date: Sun, 22 Sep 2002 16:49:20 +0000 Subject: [PATCH] Added some FIXME comments. --- C4/Biblio.pm | 12 ++++++++++-- C4/Search.pm | 2 ++ jmemberentry.pl | 1 + memberentry.pl | 1 + 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index 55a18a167d..8a913816fb 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -1,6 +1,9 @@ package C4::Biblio; # $Id$ # $Log$ +# Revision 1.10 2002/09/22 16:50:08 arensb +# Added some FIXME comments. +# # Revision 1.9 2002/09/20 12:57:46 tipaul # long is the road to 1.4.0 # * MARCadditem and MARCmoditem now wroks @@ -131,19 +134,21 @@ $VERSION = 0.01; # your exported package globals go here, # as well as any optionally exported functions -@EXPORT_OK = qw($Var1 %Hashit); +@EXPORT_OK = qw($Var1 %Hashit); # FIXME - These are never used # non-exported package globals go here -use vars qw(@more $stuff); +use vars qw(@more $stuff); # FIXME - These are never used # initalize package globals, first exported ones +# FIXME - These are never used my $Var1 = ''; my %Hashit = (); # then the others (which are still accessible as $Some::Module::stuff) +# FIXME - These are never used my $stuff = ''; my @more = (); @@ -151,11 +156,13 @@ my @more = (); # the functions below that use them. # file-private lexicals go here +# FIXME - These are never used my $priv_var = ''; my %secret_hash = (); # here's a file-private function as a closure, # callable as &$priv_func; it cannot be prototyped. +# FIXME - This is never used my $priv_func = sub { # stuff goes here. }; @@ -172,6 +179,7 @@ my $priv_func = sub { # ALLxxx subs (xxx deals with old-DB parameters, the ALLxxx deals with MARC-DB parameter) =head1 SYNOPSIS + MARCxxx related subs all subs requires/use $dbh as 1st parameter. NOTE : all those subs are private and must be used only inside Biblio.pm (called by a old API sub, or the ALLsub) diff --git a/C4/Search.pm b/C4/Search.pm index 83069b4678..642d6abf4e 100755 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -359,6 +359,8 @@ sub KeywordSearch { # field like 'string%' or field like '% string%' # can be rewritten (in MySQL, at least) as # field regexp '(^| )string'; + # However, this isn't portable. Though PostgreSQL allows you to use "~" + # instead of "regexp". my $query="Select biblionumber from biblio where ((title like '$key[0]%' or title like '% $key[0]%')"; while ($i < $count){ diff --git a/jmemberentry.pl b/jmemberentry.pl index 48212fc553..7c6418a94a 100755 --- a/jmemberentry.pl +++ b/jmemberentry.pl @@ -42,6 +42,7 @@ my $type=$input->param('type'); my $data=borrdata('',$member); my @titles = ('Miss', 'Mrs', 'Ms', 'Mr', 'Dr', 'Sir'); + # FIXME - Assumes English. This ought to be made part of i18n. my @titledata; while (@titles) { my $title = shift @titles; diff --git a/memberentry.pl b/memberentry.pl index 68093c7c26..516112aee9 100755 --- a/memberentry.pl +++ b/memberentry.pl @@ -108,6 +108,7 @@ if ($delete){ } my @titles = ('Miss', 'Mrs', 'Ms', 'Mr', 'Dr', 'Sir'); + # FIXME - Assumes English. This ought to be made part of i18n. my @titledata; while (@titles) { my %row; -- 2.39.5