From 4e817ee04c2b5fbc2353ff382c6630322e57d8ae Mon Sep 17 00:00:00 2001 From: Chris Cormack Date: Wed, 25 May 2016 14:06:28 +0000 Subject: [PATCH] Bug 16587 opac-sendshelf.pl is vulnerable to XSS To test 1/ Hit a url like http://localhost:8080/cgi-bin/koha/opac-sendshelf.pl?email=%3Cscript%3Ealert(%27XSS%27)%3C%2Fscript%3Ezz%40zz&comment=tes&shelfid=4 2/ Notice you get a js alert 3/ Apply patch 4/ Notice the js is now escaped Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt index 06a9c064d6..c5e9fe8fb7 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt @@ -13,7 +13,7 @@ [% IF ( SENT ) %]

Message sent

-

The list was sent to: [% email %]

+

The list was sent to: [% email | html %]

Back to lists

[% END %] -- 2.39.5