From 50763fe6e14909408f7cc89e200797cc2fafe7ab Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 14 Jan 2021 10:44:46 +0100 Subject: [PATCH] Bug 15448: Remove items fetch We fetch them already too many times. Signed-off-by: Jonathan Druart (cherry picked from commit 6cd68dd05bdac2787fa0b67b7f90a5836c57745c) Signed-off-by: Fridolin Somers (cherry picked from commit 54a9ef09bfe7fe8eff67a173dc7b79a278aba88f) Signed-off-by: Andrew Fuerste-Henry (cherry picked from commit bcb997bda846b589c29bb54c0ee3484989bd56c4) Signed-off-by: Victor Grousset/tuxayo --- opac/opac-reserve.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl index 887dbbc75d..93fa679ee1 100755 --- a/opac/opac-reserve.pl +++ b/opac/opac-reserve.pl @@ -453,7 +453,7 @@ foreach my $biblioNum (@biblionumbers) { my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode }); my $notforloan_label_of = { map { $_->authorised_value => $_->opac_description } @notforloan_avs }; - my $visible_items = { map { $_->itemnumber => 1 } $biblio->items->filter_by_visible_in_opac( { patron => $patron } )->as_list }; + my $visible_items = { map { $_->itemnumber => $_ } $biblio->items->filter_by_visible_in_opac( { patron => $patron } )->as_list }; # Only keep the items that are visible in the opac (i.e. those in %visible_items) # FIXME: We should get rid of itemInfos altogether and use $visible_items @@ -464,7 +464,7 @@ foreach my $biblioNum (@biblionumbers) { my $numCopiesOPACAvailable = 0; foreach my $itemInfo (@{$biblioData->{itemInfos}}) { my $itemNum = $itemInfo->{itemnumber}; - my $item = Koha::Items->find( $itemNum ); + my $item = $visible_items->{$itemNum}; my $itemLoopIter = {}; $itemLoopIter->{itemnumber} = $itemNum; -- 2.20.1