From 50b6f91094b11df73021be162c7c49dd6ca1c615 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 5 Nov 2020 06:40:42 -0500
Subject: [PATCH] Bug 26627: (QA follow-up) Remove barcode input by id
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ebb437349ebbadf90599c23a46126e5d8eda72da)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
index 27b0633604..277b677ae7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ -459,7 +459,7 @@
 
                                                 <div class="modal-footer">
                                                     <input type="hidden" name="cancel_reserve" value="0" />
-                                                    <input type="hidden" name="barcode" value="[% barcode | html %]" />
+                                                    <input id="confirm-hold-barcode" type="hidden" name="barcode" value="[% barcode | html %]" />
 
                                                     <button type="submit" class="btn btn-default approve" data-dismiss="modal">
                                                         <i class="fa fa-check"></i> Confirm hold
@@ -1037,7 +1037,8 @@
 
             $('.print').on("click",function(e){
                 this.form.print_slip.value = 1;
-                this.form.barcode.remove();
+                let barcode = document.getElementById('confirm-hold-barcode');
+                if ( barcode ) barcode.remove();
                 this.form.submit();
             });
 
-- 
2.39.5