From 54ee1259e1cfa2a0390732244edf3873206a7b74 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 3 Jan 2020 18:43:15 +0000 Subject: [PATCH] Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 2eeeaec8d5b0a92b8e0fba3ae1341d261c42d9c2) Signed-off-by: Lucas Gass --- .../prog/en/modules/circ/checkout-notes.tt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt index ec7cfaf6f0..0a386616cf 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt @@ -50,8 +50,8 @@ [% IF ( notes.count ) %]
- - + +
@@ -140,12 +140,12 @@ $(".SelectAll").on("click", function(){ $("input[name='issue_ids'][type='checkbox']").prop("checked", true); - $(".btn-sm").prop("disabled", false); + $(".markseen").prop("disabled", false); }); $(".ClearAll").on("click", function(){ $("input[name='issue_ids'][type='checkbox']").prop("checked", false); - $(".btn-sm").prop("disabled", true); + $(".markseen").prop("disabled", true); }); $(".HideSeen").on("click", function(){ @@ -158,11 +158,11 @@ $("#error").hide(); - $("input[type='checkbox']").click(function(event){ + $("#notestable").on("change", "input[type='checkbox']", function(){ if ( $("input[type='checkbox']").is(":checked") ) { - $(".btn-sm").prop("disabled", false); + $(".markseen").prop("disabled", false); } else { - $(".btn-sm").prop("disabled", true); + $(".markseen").prop("disabled", true); } }); -- 2.39.5