From 5d1501b28ecaedf42fce12bbf2b711eba75b2cec Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 29 Jan 2021 13:19:12 +0000 Subject: [PATCH] Bug 27571: "Add to lists" on MARC and ISBD view of OPAC detail page doesn't open in new window This page corrects the global click handler in the OPAC so that all "addtoshelf" links will work correctly to trigger the popup window for adding titles to a list. To test, apply the patch and test the process of adding a title to a list in the OPAC from various places: - Search results - Bibliographic detail page (normal) - Bibliographic detail page (MARC view) - Bibliographic detail page (ISBD view) Test both adding to an existing list and adding to a new list. Everything should work correctly. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 1cc252c145ff20cc01756a5aa3dbeb16cfb90e77) Signed-off-by: Fridolin Somers (cherry picked from commit 032fffa4b59154dae9d4b2c7ca5bbffb1142b565) Signed-off-by: Andrew Fuerste-Henry --- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc index 3875412a3a..c180b08b45 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ -195,9 +195,9 @@ $.widget.bridge('uitooltip', $.ui.tooltip); window.print(); return false; }); - $("#ulactioncontainer > ul > li > a.addtoshelf").on("click",function(){ - Dopop('opac-addbybiblionumber.pl?biblionumber=[% biblionumber | uri %]'); - return false; + $(".addtoshelf").on("click",function(e){ + e.preventDefault(); + Dopop( this.href ); }); $("body").on("click", ".addtocart", function(e){ e.preventDefault(); -- 2.39.5