From 5e62477823e75d19bbd0bd89bf7f2de68f7c4782 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Wed, 27 Dec 2023 17:52:57 +0000 Subject: [PATCH] Bug 35651: Add check to make sure user has advanced_editor permission To test: 1. Turn on the system preference 'EnableAdvancedCatalogingEditor'. 2. Set up a staff user with permissions to editcatlouge but make sure "Use the advanced cataloging editor (requires edit_catalogue)" if OFF. 3. Log in as that patron. 4. Go to a record or create a new one in the basic editor and see the toggle advanced editor button. 5. Try toggling it and you are logged out. 6. APPLY PATCH 7. Try 3 & 4 again, this time there should be no toggle button. 8. Log in as a patron who does havbe the "Use the advanced cataloging editor (requires edit_catalogue)" permission on. They should be able to toggle between editors. Signed-off-by: Kelly Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer (cherry picked from commit 8f13f74e39a93314abc814735b6fcd1504e49373) Signed-off-by: Fridolin Somers --- .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt index 3f09598fa1..83d34d3766 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt @@ -859,7 +859,7 @@ $(document).ready(function(){ [% END %] - [% IF Koha.Preference('EnableAdvancedCatalogingEditor') %] + [% IF ( Koha.Preference('EnableAdvancedCatalogingEditor') && CAN_user_editcatalogue_advanced_editor ) %]