From 5ece5d7c7f739cbf2d4b81be767ff89a8c1204f5 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 9 Sep 2020 15:58:04 +0000 Subject: [PATCH] Bug 26421: Use Bootstrap screen reader text class for shelf browser messages This patch udpates the markup added by Bug 26039, replacing the "hidden" class, which is no longer functional with Bootstrap 4, with "sr-only," a class designed specifically for screen reader text. The patch also corrects a typo, "shelfbrowers" -> "shelf browser" To test, apply the patch and make sure the OPACShelfBrowser system preference is enabled. View the detail page for a bibliographic record with items. In the holdings table, you should see links labeled "Browse shelf." When you open the shelf browser there should be a link at the top that reads "Close shelf browser." If you have access to a screen reader, test that the hidden text is announced by the reader. "Browse shelf (Opens below)" and "Close shelf browser (Hides shelf browser)." Signed-off-by: Stina Hallin Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart --- koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc index 253fe20893..396470d977 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc @@ -7,7 +7,7 @@ [%- IF ( starting_location ) %]Shelving location: [%- starting_location | html -%][% END -%] [%- IF ( starting_homebranch && starting_ccode ) %], [% END %] [%- IF ( starting_ccode ) %]Collection: [%- starting_ccode | html -%][% END -%] - Close shelf browser + Close shelf browser (Hides shelf browser) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 44104e1f7b..2854660887 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -1331,9 +1331,9 @@ [% ITEM_RESULT.itemcallnumber | html %] [% IF ( OPACShelfBrowser ) %] [% IF ( ITEM_RESULT.itemnumber == starting_itemnumber ) %] - (Browse shelf) + (Browse shelf (Opens below)) [% ELSE %] - (Browse shelf) + (Browse shelf (Opens below)) [% END %] [% END %] [% END %] -- 2.39.5