From 6857d4f896f5a79875ce609e54307cf8afc2b448 Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Fri, 9 Jun 2023 14:54:33 -0400 Subject: [PATCH] Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Prevent "claims returned" from being selectable from moredetail.pl, even if another lost status is already set To test: 1. Configure Claims returned i. Go to Administration > Authorized Values > LOST ii. Add a new authorized value with value:6 and description:Claims returned iii. Go to Administration > System Preferences iv. Set ClaimReturnedLostValue to 6 and save 2. Go to any title record and click the barcode for any item 3. Click the Lost status drop-down. Note that the Claims Returned option is disabled. 4. Select a Lost status and click "Set status" 5. Click the Lost status drop-down. Note that the Claims Returned option is now selectable. 6. Apply the patch and refresh the page 7. Note that the Claims Returned option is now disabled. 8. Find a different item and check it out to a customer. 9. On that customer's account, click "Claim Returned" for that item 10. Click the barcode to view moredetail for that item Note that the Lost status drop-down is disabled with Claims Returned selected Signed-off-by: Sam Lau Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi --- .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt index f51959c644..fc756aa347 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt @@ -204,10 +204,10 @@ [% END %] [% FOREACH itemlostloo IN itemlostloop %] - [% IF ClaimReturnedLostValue && !ITEM_DAT.itemlost && itemlostloo.authorised_value == ClaimReturnedLostValue #Filter claims returned status from pulldown %] - - [% ELSIF itemlostloo.authorised_value == ITEM_DAT.itemlost %] + [% IF itemlostloo.authorised_value == ITEM_DAT.itemlost %] + [% ELSIF ClaimReturnedLostValue && itemlostloo.authorised_value == ClaimReturnedLostValue #Filter claims returned status from pulldown %] + [% ELSE %] [% END %] -- 2.39.5