From 6b49a70b94d6b5e0e2e1cde3025ade1278814925 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 11 Jun 2020 12:45:57 +0100 Subject: [PATCH] Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 224b9b845c..7beeb1a969 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -131,7 +131,7 @@ [% XSLTBloc | $raw %] [% ELSE %]

[% INCLUDE 'biblio-title.inc' %]

- [% IF ( author ) %]
by [% author | html %]
[% END %] + [% IF ( author ) %]by [% author | html %][% END %] [% UNLESS ( item_level_itypes ) %] [ diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl index afaa37bcd5..8286a94fc4 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl @@ -160,14 +160,14 @@ -
+ 100,110,111,700,710,711 abc au -
+
@@ -1566,7 +1566,7 @@ -
+ @@ -1832,7 +1832,7 @@ | -
+
-- 2.39.5