From 720ed202b82e89db1af68e98fd6ac2dd465b562e Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Fri, 24 Jun 2022 16:55:25 +0100 Subject: [PATCH] Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi --- Koha/REST/V1/Items.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Koha/REST/V1/Items.pm b/Koha/REST/V1/Items.pm index 2e5478770f..88a0675257 100644 --- a/Koha/REST/V1/Items.pm +++ b/Koha/REST/V1/Items.pm @@ -19,6 +19,8 @@ use Modern::Perl; use Mojo::Base 'Mojolicious::Controller'; +use C4::Circulation qw( barcodedecode ); + use Koha::Items; use List::MoreUtils qw( any ); @@ -199,8 +201,8 @@ sub add_to_bundle { ); } - my $bundle_item_id = $c->validation->param('body')->{'external_id'}; + $bundle_item_id = barcodedecode($bundle_item_id); my $bundle_item = Koha::Items->find( { barcode => $bundle_item_id } ); unless ($bundle_item) { @@ -253,6 +255,7 @@ sub remove_from_bundle { } my $bundle_item_id = $c->validation->param('bundled_item_id'); + $bundle_item_id = barcodedecode($bundle_item_id); my $bundle_item = Koha::Items->find( { itemnumber => $bundle_item_id } ); unless ($bundle_item) { -- 2.39.5