From 7519f4d065d258653a08cf46a8b142e702ca5af0 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 11 Jun 2020 12:15:21 +0100 Subject: [PATCH] Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3e18402c240814d7f00a62c3f2359bd9b9d0a098) Signed-off-by: Lucas Gass (cherry picked from commit 0e711e024e2ac25347a17d6499289d90c6da29de) Signed-off-by: Aleisha Amohia --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 ++++---- .../bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl | 4 ++-- .../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index d15c936b5e..6a4cf5dafc 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -130,7 +130,7 @@ [% IF ( OPACXSLTDetailsDisplay ) %] [% XSLTBloc | $raw %] [% ELSE %] -

[% INCLUDE 'biblio-title.inc' %]

+

[% INCLUDE 'biblio-title.inc' %]

[% IF ( author ) %]
by [% author | html %]
[% END %] [% UNLESS ( item_level_itypes ) %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl index 45b142bddc..9d23dbe043 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl @@ -119,17 +119,17 @@ -

+

245 abhfgknps -

+
-

+

a @@ -154,7 +154,7 @@ -

+
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl index 28c770204d..3fa217f51d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl @@ -67,7 +67,7 @@ -

+

a @@ -89,7 +89,7 @@ np -

+
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl index e5afad7c67..5186823762 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl @@ -25,7 +25,7 @@ -

+

@@ -62,7 +62,7 @@ -

+
-- 2.39.5