From 77e7e11c3a0963bef8d0295eca92f49759f1f3ec Mon Sep 17 00:00:00 2001 From: =?utf8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Sat, 3 Sep 2022 14:08:50 +0300 Subject: [PATCH] Bug 28012: Creating numbering pattern: mark mandatory fields required If any of these fields were missing, notably the Numbering formula then saving the new numbering pattern silently failed, it didn't give any error but it didn't save any new pattern either. Note that there is a plan to make description field optional, so even if it currently is mandatory on the DB level we leave it optional here (and due to people using production DB's in non-strict mode which allows this to be optional). To test: 1) After applying this patch make sure all the 3 fields must be filled in /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new page and it cannot be saved without those. Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer (cherry picked from commit a69b5e6ee99478e730be574178c30f950a09532e) Signed-off-by: Fridolin Somers --- .../en/modules/serials/subscription-numberpatterns.tt | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt index 6bc37ca6f0..66439a8fc1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt @@ -69,16 +69,18 @@
  1. - - + + + Required
  2. - - + + + Required
  3. -- 2.39.5