From 7b4ee00a580807b6021758a790fec23c743719d2 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 21 Dec 2018 13:54:18 -0500 Subject: [PATCH] Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field. Test Plan: 1) Set the checked_in_ok sip account flag to 1 for an account 2) Check in an already checked in item via SIP 3) Note the alert flag is set to Y 4) Apply this patch 5) Restart SIP 6) Check the item in again 7) Note the alert flag is set to N Signed-off-by: Kyle M Hall Signed-off-by: Jill Kleven Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens --- C4/SIP/ILS/Transaction/Checkin.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm index a35009f511..77eb36161f 100644 --- a/C4/SIP/ILS/Transaction/Checkin.pm +++ b/C4/SIP/ILS/Transaction/Checkin.pm @@ -66,8 +66,6 @@ sub do_checkin { $debug and warn "do_checkin() calling AddReturn($barcode, $branch)"; my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, undef, $return_date); - $self->alert(!$return); - # ignoring messages: NotIssued, WasLost, WasTransfered # biblionumber, biblioitemnumber, itemnumber # borrowernumber, reservedate, branchcode @@ -117,7 +115,7 @@ sub do_checkin { $self->{item}->hold_patron_id( $messages->{ResFound}->{borrowernumber} ); $self->{item}->destination_loc( $messages->{ResFound}->{branchcode} ); } - $self->alert(1) if defined $self->alert_type; # alert_type could be "00", hypothetically + $self->alert(defined $self->alert_type); # alert_type could be "00", hypothetically $self->ok($return); } -- 2.39.5