From 7d2a5ef86528679bb5ad8c10cf526c203cddd9c9 Mon Sep 17 00:00:00 2001 From: Andrew Isherwood Date: Thu, 5 Mar 2020 10:26:38 +0000 Subject: [PATCH] Bug 23051: (follow-up) Remove call to GetFines As mentioned by Nick in comment #69 and subsequently discussed on Slack, the call to GetFines in renew_item was unnececcesary. It has now been removed. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize --- Koha/Account/Line.pm | 9 --------- 1 file changed, 9 deletions(-) diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm index 8a6f03091a..8f10ac3ace 100644 --- a/Koha/Account/Line.pm +++ b/Koha/Account/Line.pm @@ -827,15 +827,6 @@ sub renew_item { my $itemnumber = $self->item->itemnumber; my $borrowernumber = $self->patron->borrowernumber; - # Only do something if this item has no fines left on it - my $fine = C4::Overdues::GetFine($itemnumber, $borrowernumber); - if ($fine && $fine > 0) { - return { - itemnumber => $itemnumber, - error => 'has_fine', - success => 0 - }; - } my ( $can_renew, $error ) = C4::Circulation::CanBookBeRenewed( $borrowernumber, $itemnumber -- 2.39.5