From 87a78e5a92b9a279e2d9c524beafddead82e0ae1 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 21 Jun 2018 14:32:52 +0000 Subject: [PATCH] Bug 14222: Sort holds in OPAC by priority This patch modifies the markup of the users's holds table in the OPAC so that if hold priority is displayed, the table will be sorted by that number. To test, apply the patch and set the OPACShowHoldQueueDetails system preference to "Show priority level" or "Show holds and their priority level." - Log in to the OPAC as a user who has multiple holds with various priorities. Include priorities which could be sorted incorrectly using a text sort, e.g. 1, 10. - View the holds tab on the "your summary" page. Confirm that the priority column is sorted by default with the lowest priority holds first. - Set the OPACShowHoldQueueDetails preference to "Show holds" and confirm that the holds table still displays correctly, sorted by "Placed on" ascending. Signed-off-by: Maryse Simard Followed the test plan and the patch works. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index 134ea41262..cbe4106df0 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -577,13 +577,17 @@ Title - Placed on + [% IF ( showpriority ) %] + Placed on + [% ELSE %] + Placed on + [% END %] Expires on [% UNLESS( singleBranchMode) %] Pick up location [% END %] [% IF ( showpriority ) %] - Priority + Priority [% END %] Status [% IF SuspendHoldsOpac %] @@ -647,7 +651,7 @@ [% END %] [% IF ( showpriority ) %] - + Priority: [% RESERVE.priority %] -- 2.39.5