From 94dc265edc85027d80c43768c16b540dddff07b8 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Wed, 17 Mar 2021 13:27:27 +0200 Subject: [PATCH] Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help text The waiting reserves have always been impossible to checkout via SIP2. There was some confusion whether this is actually true but if you check the commit "Bug 25690: Remove duplicated logic in SIP2 checkouts" (338ba1d769) and the removed code around line $self->screen_msg("Item is on hold for another patron."); you will be sure that it has been impossible to checkout waiting holds. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 3aee4f4eca0a7dfbcb4704416f646dfaef39da70) Signed-off-by: Fridolin Somers (cherry picked from commit a7dc8aa2ecc89fa696faaa670aa935cd94fe3013) Signed-off-by: Andrew Fuerste-Henry --- installer/data/mysql/sysprefs.sql | 2 +- .../prog/en/modules/admin/preferences/circulation.pref | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index 9f6290dda3..78006f8f88 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -28,7 +28,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('AllowHoldsOnDamagedItems','1','','Allow hold requests to be placed on damaged items','YesNo'), ('AllowHoldsOnPatronsPossessions','1',NULL,'Allow holds on records that patron have items of it','YesNo'), ('AllowCheckoutNotes', '0', NULL, 'Allow patrons to submit notes about checked out items.','YesNo'), -('AllowItemsOnHoldCheckoutSIP','0','','Do not generate RESERVE_WAITING and RESERVED warning when checking out items reserved to someone else via SIP. This allows self checkouts for those items.','YesNo'), +('AllowItemsOnHoldCheckoutSIP','0','','Do not generate RESERVED warning when checking out items reserved to someone else via SIP. This allows self checkouts for those items.','YesNo'), ('AllowItemsOnHoldCheckoutSCO','0','','Do not generate RESERVE_WAITING and RESERVED warning in the SCO module when checking out items reserved to someone else. This allows self checkouts for those items.','YesNo'), ('AllowMultipleCovers','0','1','Allow multiple cover images to be attached to each bibliographic record.','YesNo'), ('AllowMultipleIssuesOnABiblio',1,'Allow/Don\'t allow patrons to check out multiple items from one biblio','','YesNo'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref index d847db543b..39d1346b8d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ -212,8 +212,8 @@ Circulation: yes: Allow no: "Don't allow" - checkouts of items reserved to someone else via SIP checkout messages. - - If allowed do not generate RESERVE_WAITING and RESERVED warning. - - This allows self checkouts for those items. If using the holds queue items with pending holds will be marked as "unavailable" if this set to "Don't Allow". + - If allowed do not generate RESERVED warning. + - This allows self checkouts for those items. If using the holds queue items with pending holds will be marked as "unavailable" if this set to "Don't allow". - - pref: AllowItemsOnHoldCheckoutSCO choices: -- 2.39.5