From 94f19f26fffa56af03f3832666611443147b5a77 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 15 Mar 2021 14:07:26 +0000 Subject: [PATCH] Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - The "pick up at" list will exclude the library so and additional steps must be taken to get the message - Select a patron and set their library to the one we can't pick up at. - Start the process of placing a hold on the title. - After selecting the patron to place the hold for, look at the table of items under "Place a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location." Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart (cherry picked from commit 9cc6fca618707898117363971460833ed3684539) Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 08866118fd..61586866fe 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -594,6 +594,8 @@ Cannot be transferred to pickup library [% ELSIF itemloo.not_holdable == 'pickupNotInHoldGroup' %] Only pickup locations within the same hold group are allowed + [% ELSIF itemloo.not_holdable == 'libraryNotPickupLocation' %] + Library is not a pickup location [% ELSE %] [% itemloo.not_holdable | html %] [% END %] -- 2.20.1