From 964d8cbe4c1ebbcc90c10ee9ff808ab09431cec1 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20Demians?= Date: Sat, 1 Feb 2014 09:49:38 +0100 Subject: [PATCH] Bug 11663: fix display of holding tab in Bootstap OPAC when opacbookbag syspref is disabled Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variables are not defined in template since opacbookbag is disabled. To reproduce this bug: - Choose bootstrap OPAC theme - Enable virtualsheves syspref - Disable opacbookbag syspref - Open a biblio record in OPAC detail page - You will observe that items holding tabs are not displayed as tabs but as a bulleted list Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes QA script and all tests. Confirmed display problem exists without the patch and is solved by it. Ideally we would avoid having the cart messages in the template when the feature is deactivated, but this is ok for now. Signed-off-by: Galen Charlton (cherry picked from commit e3c203aebb939af63aefc81f77474adc0234ca4c) Signed-off-by: Fridolin Somers --- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc index c3ce588d8c..8bb4ccda93 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ -108,7 +108,7 @@ //