From 971cbd5b8e0c84239763022ddf0bbceaba54beb5 Mon Sep 17 00:00:00 2001 From: Lari Taskula Date: Mon, 20 Sep 2021 22:33:42 +0000 Subject: [PATCH] Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC messaging preferences title, so it's dead code. This patch removes the useless duplicate if-statement. To test: 1. Enable EnhancedMessagingPreferencesOPAC system preference 2. Go to /cgi-bin/koha/opac-messaging.pl 3. Observe title Your messaging settings > Koha online catalog 4. Apply patch 5. Refresh page /cgi-bin/koha/opac-messaging.pl 6. Observe same title Your messaging settings > Koha online catalog 7. See patch content 8. Confirm there are no functional changes in the new logic Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt index a1406a1af4..6f4e35d8b2 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt @@ -1,6 +1,6 @@ [% USE Koha %] [% INCLUDE 'doc-head-open.inc' %] -Your messaging settings › [% IF ( LibraryNameTitle ) %][% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %][% ELSE %]Koha online[% END %] catalog +Your messaging settings › [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog [% INCLUDE 'doc-head-close.inc' %] [% BLOCK cssinclude %][% END %] -- 2.39.5