From 9b242afd75b68ed06372db95a1b46435d918871d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 8 Feb 2013 11:21:11 -0500 Subject: [PATCH] Bug 9571 [Alternate] Fix width for textareas in Edit Item screen This alternative patch modifies the script where the input markup is built and adds an alternative configuration for textareas. This gives the textareas explicit "cols" and "rows" attributes. I think this solution is preferable to a style fix because it solves the bug while eliminating some invalid markup (no "size" or "maxlength" attributes on textareas, which are invalid without explicit dimensions). To test, add a nice big chunk of text to an existing item's item field like "Public note" (952$z), save, and edit again. The field should now be displayed in a more comfortably-sized textarea. Signed-off-by: Kyle M Hall Signed-off-by: Jared Camins-Esakov --- cataloguing/additem.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl index aa7095d250..16fee3b055 100755 --- a/cataloguing/additem.pl +++ b/cataloguing/additem.pl @@ -154,6 +154,7 @@ sub generate_subfield_form { $value = $input->param('barcode'); } my $attributes_no_value = qq(tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="$subfield_data{maxlength}" ); + my $attributes_no_value_textarea = qq(tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" rows="5" cols="64" ); my $attributes = qq($attributes_no_value value="$value" ); if ( $subfieldlib->{authorised_value} ) { @@ -270,7 +271,7 @@ sub generate_subfield_form { 500 <= $tag && $tag < 600 ) ) { # oversize field (textarea) - $subfield_data{marc_value} = "\n"; + $subfield_data{marc_value} = "\n"; } else { # it's a standard field $subfield_data{marc_value} = ""; -- 2.20.1