From 9bdd33de213632168d7b4838fd6d83b5a9db00b8 Mon Sep 17 00:00:00 2001
From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Tue, 11 Aug 2015 10:19:05 +0200
Subject: [PATCH] Bug 14671: Allow correct translation of CAS authentication

In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text.
See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7

It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication.

This patch removes the use of acronym and abbr is authentication pages.

Test plan (example with fr-FR locale) :
- Without patch
- Update translation files : cd misc/translator ; perl translate update fr-FR
- You see in fr-FR-opac-bootstrap.po : msgid "If you have a "
- Is is translated in : msgstr "Si vous avez un compte "
- Apply patch
- Update translation files : cd misc/translator ; perl translate update fr-FR
- You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please "
- You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez "
- Same test for intranet authentication page
- Install the translation : cd misc/translator ; perl translate install fr-FR
- Look at the result

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Tranlated OK, tested in spanish es-ES

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt       | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
index 9ae147e5cc..b43143fd34 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
@@ -76,7 +76,7 @@
 <p>Sorry, the CAS login failed.</p>
 [% END %]
 
-<p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account,
+<p>If you have a CAS account,
 [% IF ( casServerUrl ) %]
     please <a href="[% casServerUrl %]">click here to login</a>.<p>
 [% END %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
index c474791184..6a3f9e2b5c 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
@@ -69,7 +69,7 @@
                                     <!-- This is what is displayed if cas login has failed -->
                                     <p>Sorry, the CAS login also failed, if you have a local login you may use that below.</p>
                                     [% ELSE %]
-                                    If you have a <abbr title="Central Authentication Service">CAS</abbr> account, you may use that below.
+                                    If you have a CAS account, you may use that below.
                                     [% END %]
                                     [% ELSE %]
                                     If you have a local account, you may use that below.
@@ -84,7 +84,7 @@
                                 [% END %]
                                 [% IF ( casAuthentication ) %]
                                 <h4>CAS login</h4>
-                                <p>If you do not have a Shibboleth account, but you do have a <abbr title="Central Authentication Service">CAS</abbr> account,
+                                <p>If you do not have a Shibboleth account, but you do have a CAS account,
                                 [% ELSE %]
                                 <h4>Local login</h4>
                                 <p>If you do not have a Shibboleth account, but you do have a local login, then you may login below:</p>
@@ -114,7 +114,7 @@
                                     <p>Sorry, the CAS login failed.</p>
                                 [% END %]
 
-                                <p>If you have a <abbr title="Central Authentication Service">CAS</abbr> account,
+                                <p>If you have a CAS account,
                                 [% IF ( casServerUrl ) %]
                                     please <a href="[% casServerUrl %]">click here to login</a>.<p>
                                 [% END %]
-- 
2.20.1