From 9e969e0f7b0f556dcd947c9db482540174f3f1ca Mon Sep 17 00:00:00 2001 From: Magnus Enger Date: Wed, 20 Nov 2019 15:15:15 +0100 Subject: [PATCH] Bug 24072: Typos in advance_notices.pl causes DUEDGST not to be sent There are two typos in advance_notics.pl that cause DUEDGST messages not to be sent. See Bugzilla for full details. If you think the typo is sufficiently obvious, you can just eyeball the patch and sign off, methinks. Otherwise, testing can be done something like this: - Make sure you have enabled enhanced messaging preferences, and a patron with "Email" and "Digests only" set for "Item due" messages - Issue an item to this patron, with due date today - Run something like this to generate advance notices: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/advance_notices.pl -n -c" kohadev - See that no notices are shown (-n means messages will go to stdout, instead of into the message queue). - Apply the patch and run advance_notices.pl again, as before. A DUEDGST message should now be displayed. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 1f3a9722e4f8d32c7a839137252fc935ad599f74) Signed-off-by: Lucas Gass --- misc/cronjobs/advance_notices.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl index d98783123d..af97c4103b 100755 --- a/misc/cronjobs/advance_notices.pl +++ b/misc/cronjobs/advance_notices.pl @@ -390,7 +390,7 @@ if ($digest_per_branch) { while (my ($branchcode, $digests) = each %$due_digest) { send_digests({ sth => $sth_digest, - digest => $due_digest, + digests => $due_digest, letter_code => 'DUEDGST', branchcode => $branchcode, get_item_info => sub { @@ -419,7 +419,7 @@ if ($digest_per_branch) { send_digests({ sth => $sth_digest, - digest => $due_digest, + digests => $due_digest, letter_code => 'DUEDGST', get_item_info => sub { my $params = shift; -- 2.20.1