From a000d95a4d322607eccdbf08abc94dd78d4e5617 Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Wed, 28 Jun 2017 13:05:42 -0400 Subject: [PATCH] Bug 18633: Remove useless use of CGI TT plugin MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The form is sent using AJAX so there is never a query string in the URL (no POST parameters either) Tested both patches together, item search behaves as before, log entries are gone Signed-off-by: Marc Véron Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- .../prog/en/modules/catalogue/itemsearch.tt | 87 +++---------------- 1 file changed, 13 insertions(+), 74 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt index 3a70dad636..f7d5a3c029 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt @@ -1,4 +1,3 @@ -[% USE CGI %] [% USE JSON.Escape %] [% BLOCK form_label %] @@ -34,57 +33,29 @@ - [% SET values = CGI.param(name) %] [% END %] [% BLOCK form_field_select_option %] - [% IF params.f == value %] - - [% ELSE %] - - [% END %] + [% END %] [% BLOCK form_field_select_text %]
- [% IF params.exists('c') %] - - [% ELSE %] - - [% END %] + - +
[% END %] -[% BLOCK form_field_select_text_block %] - [% c = CGI.param('c').list %] - [% f = CGI.param('f').list %] - [% q = CGI.param('q').list %] - [% op = CGI.param('op').list %] - [% IF q.size %] - [% size = q.size - 1 %] - [% FOREACH i IN [0 .. size] %] - [% - params = { - f => f.$i - q = q.$i - op = op.$i - } - %] - [% IF i > 0 %] - [% j = i - 1 %] - [% params.c = c.$j %] - [% END %] - [% INCLUDE form_field_select_text params=params %] - [% END %] - [% ELSE %] - [% INCLUDE form_field_select_text %] - [% END %] -[% END %] - [% BLOCK form_field_radio_yes_no %]
@@ -455,7 +396,7 @@ [% END %]
- [% INCLUDE form_field_select_text_block %] + [% INCLUDE form_field_select_text %]

You can use the following wildcard characters: % _

% matches any number of characters

_ matches only a single character

@@ -463,14 +404,12 @@
- [% value = CGI.param('itemcallnumber_from') %] - + (inclusive)
- [% value = CGI.param('itemcallnumber_to') %] - + (inclusive)
[% INCLUDE form_field_radio_yes_no name="damaged" %] -- 2.39.5