From a2887ac9cfe6053515aae60a3d95acc4fa41bbbb Mon Sep 17 00:00:00 2001 From: Olli-Antti Kivilahti Date: Thu, 30 Oct 2014 14:57:09 +0200 Subject: [PATCH] Bug 13168 - "Today's checkouts" sort improperly because issuedate lacks seconds. TO REPLICATE: Prepare a bunch of Items (6+) for checking out, or have a set of barcodes ready for copy-pasting. Check-out those items quickly within one minute and observe that the sorting order is not always from the first checkout to the last. This is because the issuedate doesn't have seconds defined. AFTER THIS The bunch of Items is sorted properly. Tiny patch, works as expected. Passed QA script. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Mason James --- C4/Circulation.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 4e84694108..6ddf676ec0 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1258,9 +1258,10 @@ sub AddIssue { $sth->execute( $borrower->{'borrowernumber'}, # borrowernumber $item->{'itemnumber'}, # itemnumber - $issuedate->strftime('%Y-%m-%d %H:%M:00'), # issuedate - $datedue->strftime('%Y-%m-%d %H:%M:00'), # date_due - C4::Context->userenv->{'branch'} # branchcode + $issuedate->strftime('%Y-%m-%d %H:%M:%S'), # issuedate + $datedue->strftime('%Y-%m-%d %H:%M:%S'), # date_due + C4::Context->userenv->{'branch'}, # branchcode + $auto_renew ? 1 : 0 # automatic renewal ); if ( C4::Context->preference('ReturnToShelvingCart') ) { ## ReturnToShelvingCart is on, anything issued should be taken off the cart. CartToShelf( $item->{'itemnumber'} ); -- 2.39.5