From a4baa4df1843f1390f372d1569eb446171705742 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 1 Sep 2011 11:53:16 +0200 Subject: [PATCH] 6278 Funny translation bug with XSLT subfieldSelect parameters This patch resolves the situation of translating the parameters at (meaning subfield a and t) of subfieldSelect by replacing at with a_t. This string will not be translated and the xslt function subfieldSelect just ignores the underscore. It is a pragmatic and easy solution. Theoretically, we should look for a solution in the translation parser. This is much harder and would probably not result in better code in those modules. Test this patch with the following remarks in mind: 1) This patch deals with XSLT. So you should enable XSLT at OPAC detail. 2) In English or any language not translating the word at: Just check if the links for a MARC 490, 773, 780 or 785 still work at the opac detail page. 3) For a language translating the word at (like Dutch where at becomes bij), you should first rerun your translation process (at least for the OPAC). 4) In that language: Check the results on the vernacular opac detail page for MARC 490, 773, 780 or 785. Without the patch, you would not see a link following e.g. the Series label (with 490 first indicator set to 1). With the patch, you should see a link now. Signed-off-by: Katrin Fischer Pragmatic solution for an annoying problem. Signed-off-by: Ian Walls Signed-off-by: Chris Cormack --- .../opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl | 10 +++++----- .../opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl | 4 ++-- .../opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl index 3956a595ee..411adad2ea 100755 --- a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl @@ -246,7 +246,7 @@ - at + a_t @@ -257,7 +257,7 @@ - at + a_t @@ -668,7 +668,7 @@ - at + a_t @@ -791,7 +791,7 @@ - at + a_t @@ -853,7 +853,7 @@ - at + a_t diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl index 961f0c9480..d2b6b1b727 100644 --- a/koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl @@ -419,7 +419,7 @@ - at + a_t /cgi-bin/koha/opac-search.pl?q= @@ -469,7 +469,7 @@ - at + a_t diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl index 2832b6b27b..61054ea3c7 100644 --- a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl @@ -411,7 +411,7 @@ - at + a_t /cgi-bin/koha/opac-search.pl?q= @@ -464,7 +464,7 @@ - at + a_t -- 2.39.5