From a681830f2ba36496eb7b86d562d1a625b7e04c94 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 16 Jan 2019 14:25:07 -0500 Subject: [PATCH] Bug 22144: Add method metadata() to Koha::Biblio It would be very convenient to be able to retrieve a bib's attached metadata objects directly from the biblio object. This would be very useful for Template Toolkit syntax in slips and notices where a library would like to use arbitrary metadata fields that aren't stored in the database. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Biblio.t Signed-off-by: Te Rahui Tunua Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens --- Koha/Biblio.pm | 23 +++++++++++++-- Koha/Biblio/Metadata.pm | 24 +++++++++++++++ t/db_dependent/Koha/Biblio.t | 57 ++++++++++++++++++++++++++++++++++++ 3 files changed, 101 insertions(+), 3 deletions(-) create mode 100644 t/db_dependent/Koha/Biblio.t diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm index 1dca4d9cf6..d2e4d4d321 100644 --- a/Koha/Biblio.pm +++ b/Koha/Biblio.pm @@ -28,12 +28,13 @@ use Koha::DateUtils qw( dt_from_string ); use base qw(Koha::Object); -use Koha::Items; -use Koha::Biblioitems; -use Koha::ArticleRequests; use Koha::ArticleRequest::Status; +use Koha::ArticleRequests; +use Koha::Biblio::Metadatas; +use Koha::Biblioitems; use Koha::IssuingRules; use Koha::Item::Transfer::Limits; +use Koha::Items; use Koha::Libraries; use Koha::Subscriptions; @@ -61,6 +62,22 @@ sub store { return $self->SUPER::store; } +=head3 metadata + +my $metadata = $biblio->metadata(); + +Returns a Koha::Biblio::Metadata object + +=cut + +sub metadata { + my ( $self ) = @_; + + $self->{_metadata} ||= Koha::Biblio::Metadatas->find( { biblionumber => $self->id } ); + + return $self->{_metadata}; +} + =head3 subtitles my @subtitles = $biblio->subtitles(); diff --git a/Koha/Biblio/Metadata.pm b/Koha/Biblio/Metadata.pm index f271f6f824..cf553731b0 100644 --- a/Koha/Biblio/Metadata.pm +++ b/Koha/Biblio/Metadata.pm @@ -19,6 +19,8 @@ use Modern::Perl; use Carp; +use C4::Biblio qw(); + use Koha::Database; use base qw(Koha::Object); @@ -33,6 +35,28 @@ Koha::Metadata - Koha Metadata Object class =cut +=head3 record + +my @record = $biblio->record($params); + +Returns a MARC::Record object for a record. + +This method accepts the same paramters as C4::Biblio::GetMarcBiblio, +but does not require the 'biblionumber' parameter. + +=cut + +sub record { + my ( $self, $params ) = @_; + + $params->{biblionumber} = $self->biblionumber; + + my $record = C4::Biblio::GetMarcBiblio($params); + + return $record; +} + + =head3 type =cut diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t new file mode 100644 index 0000000000..281ad652ce --- /dev/null +++ b/t/db_dependent/Koha/Biblio.t @@ -0,0 +1,57 @@ +#!/usr/bin/perl + +# This file is part of Koha. +# +# Koha is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# Koha is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Koha; if not, see . + +use Modern::Perl; + +use Test::More tests => 3; + +use C4::Biblio; +use Koha::Database; + +BEGIN { + use_ok('Koha::Biblio'); + use_ok('Koha::Biblios'); +} + +my $schema = Koha::Database->new->schema; + +subtest 'metadata() tests' => sub { + + plan tests => 4; + + $schema->storage->txn_begin; + + my $title = 'Oranges and Peaches'; + + my $record = MARC::Record->new(); + my $field = MARC::Field->new('245','','','a' => $title); + $record->append_fields( $field ); + my ($biblionumber) = C4::Biblio::AddBiblio($record, ''); + + my $biblio = Koha::Biblios->find( $biblionumber ); + is( ref $biblio, 'Koha::Biblio', 'Found a Koha::Biblio object' ); + + my $metadata = $biblio->metadata; + is( ref $metadata, 'Koha::Biblio::Metadata', 'Method metadata() returned a Koha::Biblio::Metadata object' ); + + my $record2 = $metadata->record; + is( ref $record2, 'MARC::Record', 'Method record() returned a MARC::Record object' ); + + is( $record2->field('245')->subfield("a"), $title, 'Title in 245$a matches title from original record object' ); + + $schema->storage->txn_rollback; +}; -- 2.39.5