From a9df4daab1f780f14fed1fba9f4afad8c4c73d30 Mon Sep 17 00:00:00 2001
From: ava li <rubyli208@gmail.com>
Date: Wed, 20 Jan 2021 22:37:36 +0000
Subject: [PATCH] Bug 27398: Made values in number patterns subscription length
 translatable

TEST PLAN:
Check that the subscription length options when editing or adding a
numbering pattern in the serials module are translatable. check that
the hard coded values are gone.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../prog/en/modules/serials/subscription-numberpatterns.tt  | 6 +++---
 serials/subscription-numberpatterns.pl                      | 4 ----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
index 2d58cefebe..4480f47efa 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
@@ -179,9 +179,9 @@
                 <li>
                   <label for="sublength">Subscription length:</label>
                   <select id="subtype">
-                    [% FOREACH subtype IN subtypes_loop %]
-                      <option value="[% subtype.value | html %]">[% subtype.value | html %]</option>
-                    [% END %]
+                    <option value="issues">issues</option>
+                    <option value="weeks">weeks</option>
+                    <option value="months">months</option>
                   </select>
                   <input type="text" id="sublength" size="3" />
                 </li>
diff --git a/serials/subscription-numberpatterns.pl b/serials/subscription-numberpatterns.pl
index 99969b1256..a84c304ac8 100755
--- a/serials/subscription-numberpatterns.pl
+++ b/serials/subscription-numberpatterns.pl
@@ -102,9 +102,6 @@ if($op && ($op eq 'new' || $op eq 'modify')) {
         }
     }
     my @frequencies = GetSubscriptionFrequencies();
-    my @subtypes;
-    push @subtypes, { value => $_ } for (qw/ issues weeks months /);
-
     my $languages = [ map {
         {
             language => $_->{iso639_2_code},
@@ -115,7 +112,6 @@ if($op && ($op eq 'new' || $op eq 'modify')) {
     $template->param(
         $op => 1,
         frequencies_loop => \@frequencies,
-        subtypes_loop => \@subtypes,
         locales => $languages,
     );
     output_html_with_http_headers $input, $cookie, $template->output;
-- 
2.39.5